diff for duplicates of <5120EDF8.7010503@bfs.de> diff --git a/a/1.txt b/N1/1.txt index 108bd30..1642408 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -17,10 +17,10 @@ Am 16.02.2013 18:56, schrieb Kumar Amit Mehta: > struct vxge_hw_vpath_stats_sw_info *sw_stats; > struct vxge_hw_vpath_reg __iomem *vp_reg; > -> - if (vpath = NULL) { +> - if (vpath == NULL) { > - alarm_event = VXGE_HW_SET_LEVEL(VXGE_HW_EVENT_UNKNOWN, > - alarm_event); -> + if (vpath = NULL) +> + if (vpath == NULL) > goto out2; > - } > @@ -32,18 +32,18 @@ Am 16.02.2013 18:56, schrieb Kumar Amit Mehta: > hldev->stats.sw_dev_err_stats.vpath_alarms++; > + __vxge_hw_device_handle_error(hldev, vpath->vp_id, alarm_event); > out2: -> if ((alarm_event = VXGE_HW_EVENT_ALARM_CLEARED) || -> (alarm_event = VXGE_HW_EVENT_UNKNOWN)) +> if ((alarm_event == VXGE_HW_EVENT_ALARM_CLEARED) || +> (alarm_event == VXGE_HW_EVENT_UNKNOWN)) > return VXGE_HW_OK; > > - __vxge_hw_device_handle_error(hldev, vpath->vp_id, alarm_event); > - -> if (alarm_event = VXGE_HW_EVENT_SERR) +> if (alarm_event == VXGE_HW_EVENT_SERR) > return VXGE_HW_ERR_CRITICAL; > the patch looks ok. -it would be nice if someone would rewrite the if (alarm_event = x ) stuff +it would be nice if someone would rewrite the if (alarm_event == x ) stuff using switch or more if()'s it is hardly readable this way. just my 2 cents, diff --git a/a/content_digest b/N1/content_digest index c3dd19d..514909f 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\01361037394-14731-1-git-send-email-gmate.amit@gmail.com\0" "From\0walter harms <wharms@bfs.de>\0" "Subject\0Re: [PATCH] ethernet: neterion: vxge: vxge-traffic.c: fix for a potential NULL pointer dereference\0" - "Date\0Sun, 17 Feb 2013 14:49:28 +0000\0" + "Date\0Sun, 17 Feb 2013 15:49:28 +0100\0" "To\0Kumar Amit Mehta <gmate.amit@gmail.com>\0" "Cc\0jdmason@kudzu.us" davem@davemloft.net @@ -30,10 +30,10 @@ "> \tstruct vxge_hw_vpath_stats_sw_info *sw_stats;\n" "> \tstruct vxge_hw_vpath_reg __iomem *vp_reg;\n" "> \n" - "> -\tif (vpath = NULL) {\n" + "> -\tif (vpath == NULL) {\n" "> -\t\talarm_event = VXGE_HW_SET_LEVEL(VXGE_HW_EVENT_UNKNOWN,\n" "> -\t\t\talarm_event);\n" - "> +\tif (vpath = NULL)\n" + "> +\tif (vpath == NULL)\n" "> \t\tgoto out2;\n" "> -\t}\n" "> \n" @@ -45,22 +45,22 @@ "> \thldev->stats.sw_dev_err_stats.vpath_alarms++;\n" "> +\t__vxge_hw_device_handle_error(hldev, vpath->vp_id, alarm_event);\n" "> out2:\n" - "> \tif ((alarm_event = VXGE_HW_EVENT_ALARM_CLEARED) ||\n" - "> \t\t(alarm_event = VXGE_HW_EVENT_UNKNOWN))\n" + "> \tif ((alarm_event == VXGE_HW_EVENT_ALARM_CLEARED) ||\n" + "> \t\t(alarm_event == VXGE_HW_EVENT_UNKNOWN))\n" "> \t\treturn VXGE_HW_OK;\n" "> \n" "> -\t__vxge_hw_device_handle_error(hldev, vpath->vp_id, alarm_event);\n" "> -\n" - "> \tif (alarm_event = VXGE_HW_EVENT_SERR)\n" + "> \tif (alarm_event == VXGE_HW_EVENT_SERR)\n" "> \t\treturn VXGE_HW_ERR_CRITICAL;\n" "> \n" "\n" "the patch looks ok.\n" - "it would be nice if someone would rewrite the if (alarm_event = x ) stuff\n" + "it would be nice if someone would rewrite the if (alarm_event == x ) stuff\n" "using switch or more if()'s it is hardly readable this way.\n" "\n" "just my 2 cents,\n" "re,\n" wh -055cd0fcb451acb10f9912f2fe3b2a9a41b899c7f93016630d27052d8dcae5e0 +7087d40a7666edb82f3e599bc454216dc701baa80c5046c1616abbfa0df7dd89
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.