From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dirk Behme Subject: Re: [PATCH] serial: imx: fix uninitialized variable warning Date: Mon, 18 Feb 2013 08:53:43 +0100 Message-ID: <5121DE07.8060908@de.bosch.com> References: <1361164536-1351-1-git-send-email-shawn.guo@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1361164536-1351-1-git-send-email-shawn.guo@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Shawn Guo Cc: Greg Kroah-Hartman , Thomas Gleixner , "linux-arm-kernel@lists.infradead.org" , "linux-serial@vger.kernel.org" List-Id: linux-serial@vger.kernel.org T24gMTguMDIuMjAxMyAwNjoxNSwgU2hhd24gR3VvIHdyb3RlOgo+IENvbW1pdCA2NzdmZTU1IChz ZXJpYWw6IGlteDogRml4IHJlY3Vyc2l2ZSBsb2NraW5nIGJ1ZykgaW50cm9kdWNlcyBhbgo+IHVu aW5pdGlhbGl6ZWQgdmFyaWFibGUgd2FybmluZyBhcyBiZWxvdy4KPiAKPiAgIENDICAgICAgZHJp dmVycy90dHkvc2VyaWFsL2lteC5vCj4gZHJpdmVycy90dHkvc2VyaWFsL2lteC5jOiBJbiBmdW5j dGlvbiDigJhpbXhfY29uc29sZV93cml0ZeKAmToKPiBpbmNsdWRlL2xpbnV4L3NwaW5sb2NrLmg6 MzQwOjI6IHdhcm5pbmc6IOKAmGZsYWdz4oCZIG1heSBiZSB1c2VkIHVuaW5pdGlhbGl6ZWQgaW4g dGhpcyBmdW5jdGlvbiBbLVd1bmluaXRpYWxpemVkXQo+IGRyaXZlcnMvdHR5L3NlcmlhbC9pbXgu YzoxMjE0OjE2OiBub3RlOiDigJhmbGFnc+KAmSB3YXMgZGVjbGFyZWQgaGVyZQo+IAo+IEluaXRp YWxpemUgdGhlIHZhcmlhYmxlIHRvIHN1cHByZXNzIHRoZSB3YXJuaW5nLgo+IAo+IFNpZ25lZC1v ZmYtYnk6IFNoYXduIEd1byA8c2hhd24uZ3VvQGxpbmFyby5vcmc+CgpBY2tlZC1ieTogRGlyayBC ZWhtZSA8ZGlyay5iZWhtZUBkZS5ib3NjaC5jb20+CgpUaGFua3MKCkRpcmsKCj4gLS0tCj4gIGRy aXZlcnMvdHR5L3NlcmlhbC9pbXguYyB8ICAgIDIgKy0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5z ZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdHR5L3Nl cmlhbC9pbXguYyBiL2RyaXZlcnMvdHR5L3NlcmlhbC9pbXguYwo+IGluZGV4IGFkZjc2MTEuLjE0 N2M5ZTEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy90dHkvc2VyaWFsL2lteC5jCj4gKysrIGIvZHJp dmVycy90dHkvc2VyaWFsL2lteC5jCj4gQEAgLTEyMTEsNyArMTIxMSw3IEBAIGlteF9jb25zb2xl X3dyaXRlKHN0cnVjdCBjb25zb2xlICpjbywgY29uc3QgY2hhciAqcywgdW5zaWduZWQgaW50IGNv dW50KQo+ICAJc3RydWN0IGlteF9wb3J0ICpzcG9ydCA9IGlteF9wb3J0c1tjby0+aW5kZXhdOwo+ ICAJc3RydWN0IGlteF9wb3J0X3VjcnMgb2xkX3VjcjsKPiAgCXVuc2lnbmVkIGludCB1Y3IxOwo+ IC0JdW5zaWduZWQgbG9uZyBmbGFnczsKPiArCXVuc2lnbmVkIGxvbmcgZmxhZ3MgPSAwOwo+ICAJ aW50IGxvY2tlZCA9IDE7Cj4gIAo+ICAJaWYgKHNwb3J0LT5wb3J0LnN5c3JxKQoKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwg bWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8v bGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: dirk.behme@de.bosch.com (Dirk Behme) Date: Mon, 18 Feb 2013 08:53:43 +0100 Subject: [PATCH] serial: imx: fix uninitialized variable warning In-Reply-To: <1361164536-1351-1-git-send-email-shawn.guo@linaro.org> References: <1361164536-1351-1-git-send-email-shawn.guo@linaro.org> Message-ID: <5121DE07.8060908@de.bosch.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 18.02.2013 06:15, Shawn Guo wrote: > Commit 677fe55 (serial: imx: Fix recursive locking bug) introduces an > uninitialized variable warning as below. > > CC drivers/tty/serial/imx.o > drivers/tty/serial/imx.c: In function ?imx_console_write?: > include/linux/spinlock.h:340:2: warning: ?flags? may be used uninitialized in this function [-Wuninitialized] > drivers/tty/serial/imx.c:1214:16: note: ?flags? was declared here > > Initialize the variable to suppress the warning. > > Signed-off-by: Shawn Guo Acked-by: Dirk Behme Thanks Dirk > --- > drivers/tty/serial/imx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c > index adf7611..147c9e1 100644 > --- a/drivers/tty/serial/imx.c > +++ b/drivers/tty/serial/imx.c > @@ -1211,7 +1211,7 @@ imx_console_write(struct console *co, const char *s, unsigned int count) > struct imx_port *sport = imx_ports[co->index]; > struct imx_port_ucrs old_ucr; > unsigned int ucr1; > - unsigned long flags; > + unsigned long flags = 0; > int locked = 1; > > if (sport->port.sysrq)