From: Tomi Valkeinen <tomba@iki.fi>
To: Rob Clark <robdclark@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [pull] tilcdc-next for 3.9
Date: Mon, 18 Feb 2013 11:02:41 +0200 [thread overview]
Message-ID: <5121EE31.7020807@iki.fi> (raw)
In-Reply-To: <CAF6AEGsR3+1rhK=Yabt0AAUFK2Yt3VDCDPDvavAz_uxGaRaC_A@mail.gmail.com>
On 2013-02-18 01:02, Rob Clark wrote:
> Hi Dave,
>
> Here is pull request for tilcdc drm driver.. it also includes a
> handful of dependent patches from me, plus a couple fixes from Daniel
> Vetter which haven't showed up yet in drm-next.
Why is the TFP410 driver integrated into the tilcdc, but the TDA998x is
a generic driver?
I think the DT bindings do not match the DT guidelines. For example,
compatible = "tilcdc,slave" should be "ti,tilcdc,slave". And TI specific
properties should also be prepended with "ti,".
Who is going to maintain this now that you're no longer in TI? I presume
you may do some small stuff, but I think this driver needs quite a lot
of further development in the future.
But my main concern for this series is still that it creates custom
panel stuff, and adds DT bindings for them. Which means we need to
support those custom DT bindings in the future, even though it's quite
sure that CDF should be used also for this driver, changing the bindings.
Tomi
next prev parent reply other threads:[~2013-02-18 9:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-17 23:02 [pull] tilcdc-next for 3.9 Rob Clark
2013-02-18 9:02 ` Tomi Valkeinen [this message]
2013-02-18 10:03 ` Daniel Vetter
2013-02-18 10:16 ` Tomi Valkeinen
2013-02-18 16:49 ` Daniel Vetter
2013-02-18 12:32 ` Rob Clark
2013-02-18 12:26 ` Rob Clark
2013-02-18 12:32 ` Tomi Valkeinen
2013-02-18 12:35 ` Rob Clark
2013-02-18 12:40 ` Tomi Valkeinen
2013-02-18 14:46 ` Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5121EE31.7020807@iki.fi \
--to=tomba@iki.fi \
--cc=dri-devel@lists.freedesktop.org \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.