From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 9/9] dfu: Support larger than memory transfers.
Date: Mon, 18 Feb 2013 08:51:18 -0500 [thread overview]
Message-ID: <512231D6.605@ti.com> (raw)
In-Reply-To: <20130218110142.3befd1f8@amdc308.digital.local>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 02/18/2013 05:01 AM, Lukasz Majewski wrote:
> Hi Tom,
>
>> On Fri, Nov 30, 2012 at 08:01:12PM +0200, Pantelis Antoniou
>> wrote:
>>
>>> We didn't support upload/download larger than available
>>> memory. This is pretty bad when you have to update your root
>>> filesystem for example.
>>>
>>> This patch removes the limitation (and the crashes when you
>>> transfered any file larger than 4MB). On top of that reduces
>>> the huge dfu buffer from 4MB to just 64K, which was over the
>>> top.
>>>
>>> The sequence number is a 16 bit counter; make sure we handle
>>> rollover correctly. This fixes the wrong transfers for large (>
>>> 256MB) images.
>>>
>>> Also utilize a variable to handle initialization, so that we
>>> don't rely on just the counter sent by the host.
>>>
>>> Signed-off-by: Pantelis Antoniou
>>> <panto@antoniou-consulting.com>
>>
>> To be clear, patches 1-8 are good and we should take, but this
>> one means we can't use FAT/EXT* partitions without more work. I
>> would suggest that we set this part aside for a moment and
>> perhaps limit transfers that are larget than RAM to RAW only
>> where we can write in chunks today.
>>
>
> As fair as I remember, some additional work needs to be done with
> composite.c file (to remove nasty #ifdefs). There was a problem
> with newer version of dfu-utils (new handling of descriptors).
I thought it ended up being resolved. I'll have to re-read the thread
again I guess.
- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJRIjHWAAoJENk4IS6UOR1WEs0P/07uTOJRh+8hBgnpcXwBZ8zD
keEtN8vHs3JYOjW1k6styAFNGXy+PBhOJNOIx6ClsdTvCRU8FtGh09SZUAYBrZEj
5WbfqGaeFWY9bpgAhwsNRMXD3mcHq3EGvRm0Ga+ep/EDFd+lgswvfx9EtgxkOjy5
MM0G4BnjwJxWM4DW2Wkk/rXI7Xy8jpVn3abUPLva4iY8X5L6ez9GXp/VNv6nCoNI
i+LuGXEnv7BsO9g+x5pvYlnQeMC5BPC7vKNMq9dj8o6MZ/Q7jCQkqz85GIqyDTta
UByzr24G4xK5m7V0iFSlV7fnRHjcg7q+uAB6u2YSibssyibIuLoJA2VdiGZqp8oH
OUBQ3L2v84QHhcKTQm/yqcQ4FWHaHQ369v4QwnON29yFqtb7Z/M3GEKCqPbPIlge
eg+Bb8fymdjELQT4Bo0+EkydlvaQOhkSjxBlVa9GTkRyoPxpE7RNY5lgciseVZO4
hKG/Xfnce7fpQNoE8fJCWRslQp3sOiDE65gFRzNJN/15i+my+xYmN5HiNPWhcgmI
2EVJGx9/LXqZ6yGZh8bQCC3yvNnshG+cm4qAj58ytkLjVSVnsd7yxFYbexUTEJ0q
YwOmE/72cgL/3IzpRUmh4o5G+uFJqhFx7zndMQyItdTN09mhZu7dCUtgud66A1Qg
wUiQkeF4sWubUMIpYUvz
=L9X2
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2013-02-18 13:51 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-30 18:01 [U-Boot] [PATCH v3 0/9] USB: Gadget & DFU related fixes Pantelis Antoniou
2012-11-30 18:01 ` [U-Boot] [PATCH v3 1/9] usb: Fix bug when both DFU & ETHER are defined Pantelis Antoniou
2012-12-01 5:30 ` Marek Vasut
2012-12-03 10:10 ` Pantelis Antoniou
2012-11-30 18:01 ` [U-Boot] [PATCH v3 2/9] g_dnl: Issue connect/disconnect as appropriate Pantelis Antoniou
2012-11-30 18:01 ` [U-Boot] [PATCH v3 3/9] g_dnl: Properly terminate string list Pantelis Antoniou
2012-11-30 18:01 ` [U-Boot] [PATCH v3 4/9] dfu: Only perform DFU board_usb_init() for TRATS Pantelis Antoniou
2012-12-01 5:31 ` Marek Vasut
2012-11-30 18:01 ` [U-Boot] [PATCH v3 5/9] dfu: Fix crash when wrong number of arguments given Pantelis Antoniou
2012-11-30 18:01 ` [U-Boot] [PATCH v3 6/9] dfu: Send correct DFU response from composite_setup Pantelis Antoniou
2012-12-10 17:11 ` Lukasz Majewski
2012-12-10 18:21 ` Pantelis Antoniou
2012-12-10 19:26 ` Lukasz Majewski
2012-12-11 0:47 ` Marek Vasut
2012-12-11 8:40 ` Lukasz Majewski
2012-12-11 10:47 ` Wolfgang Denk
2012-12-11 13:44 ` Tom Rini
2012-12-12 17:55 ` Marek Vasut
2012-12-12 18:03 ` Tom Rini
2012-12-11 11:02 ` Lukasz Majewski
2012-12-11 11:23 ` Pantelis Antoniou
2012-12-11 11:28 ` Robert P. J. Day
2012-12-12 21:42 ` Marek Vasut
2012-12-12 21:40 ` Marek Vasut
2012-12-11 11:18 ` Lukasz Majewski
2012-11-30 18:01 ` [U-Boot] [PATCH v3 7/9] dfu: Properly zero out timeout value Pantelis Antoniou
2012-11-30 18:01 ` [U-Boot] [PATCH v3 8/9] dfu: Add a partition type target Pantelis Antoniou
2012-11-30 18:01 ` [U-Boot] [PATCH v3 9/9] dfu: Support larger than memory transfers Pantelis Antoniou
2013-02-12 20:51 ` Tom Rini
2013-02-18 10:01 ` Lukasz Majewski
2013-02-18 12:38 ` Marek Vasut
2013-02-18 13:51 ` Tom Rini [this message]
2013-02-18 21:08 ` Tom Rini
2013-02-20 7:17 ` Lukasz Majewski
2012-12-01 5:32 ` [U-Boot] [PATCH v3 0/9] USB: Gadget & DFU related fixes Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512231D6.605@ti.com \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.