From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 984E1C25B78 for ; Tue, 28 May 2024 14:34:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0P/WWj5B0DfyrTjWtHXfke1NUs/epqWbeWI3ORPht2g=; b=WprC9JMV5sggik PW8yaZ1YFg9aZS+7Xw73sn9ZzjYZECu2hvNm8aHdpwrL2gKxjd+KLp7cURfaw4dEdcX95OpeDfRmw QDObyPJ+mV831hV4V7o6PbZCsDO2sLGj0XSOJuHv1SwQDHErYN2OMyMo2ybjJ78yWfRIaOo7PAFmM dGNKi48UbHXYOYTjb5a0szxLxMPjb7A7kbooUnH4ighNsISrPeG/Cs32Tu3W+PyMQS3rdis8Pp6oD cZtsFoqculpLq3YgKYNoHcpq5rK7cBQZgpi+C8awg4QKfPW8wn8V3+uPgXeX7in3ZiQTAMBjz7O+W Jxz3L4k0e4EfRwojP0NQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBxuP-000000012hv-10Dn; Tue, 28 May 2024 14:34:37 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBxuM-000000012h6-0YK8; Tue, 28 May 2024 14:34:35 +0000 Received: from [213.70.33.226] (helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sBxuB-0004aE-9M; Tue, 28 May 2024 16:34:23 +0200 From: Heiko Stuebner To: Alexey Charkov , Dragan Simic , Quentin Schulz Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Daniel Lezcano , Viresh Kumar , Chen-Yu Tsai , Diederik de Haas , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 0/6] RK3588 and Rock 5B dts additions: thermal, OPP and fan Date: Tue, 28 May 2024 16:34:21 +0200 Message-ID: <5122636.irdbgypaU6@phil> In-Reply-To: References: <20240506-rk-dts-additions-v4-0-271023ddfd40@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240528_073434_199417_84A14FC4 X-CRM114-Status: GOOD ( 41.94 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGkgRHJhZ2FuLAoKQW0gRGllbnN0YWcsIDI4LiBNYWkgMjAyNCwgMTY6MDU6MDQgQ0VTVCBzY2hy aWViIERyYWdhbiBTaW1pYzoKPiBPbiAyMDI0LTA1LTI4IDExOjQ5LCBBbGV4ZXkgQ2hhcmtvdiB3 cm90ZToKPiA+IE9uIE1vbiwgTWF5IDYsIDIwMjQgYXQgMTozN+KAr1BNIEFsZXhleSBDaGFya292 IDxhbGNoYXJrQGdtYWlsLmNvbT4gCj4gPiB3cm90ZToKPiA+PiAKPiA+PiBUaGlzIGVuYWJsZXMg dGhlcm1hbCBtb25pdG9yaW5nIGFuZCBDUFUgRFZGUyBvbiBSSzM1ODgocyksIGFzIHdlbGwgYXMK PiA+PiBhY3RpdmUgY29vbGluZyBvbiBSYWR4YSBSb2NrIDVCIHZpYSB0aGUgcHJvdmlkZWQgUFdN IGZhbi4KPiA+PiAKPiA+PiBTb21lIFJLMzU4OCBib2FyZHMgdXNlIHNlcGFyYXRlIHJlZ3VsYXRv cnMgdG8gc3VwcGx5IENQVXMgYW5kIHRoZWlyCj4gPj4gcmVzcGVjdGl2ZSBtZW1vcnkgaW50ZXJm YWNlcywgc28gdGhpcyBpcyBoYW5kbGVkIGJ5IGNvdXBsaW5nIHRob3NlCj4gPj4gcmVndWxhdG9y cyBpbiBhZmZlY3RlZCBib2FyZHMnIGRldmljZSB0cmVlcyB0byBlbnN1cmUgdGhhdCB0aGVpcgo+ ID4+IHZvbHRhZ2UgaXMgYWRqdXN0ZWQgaW4gc3RlcC4KPiA+PiAKPiA+PiBUaGlzIGFsc28gZW5h YmxlcyB0aGUgYnVpbHQtaW4gdGhlcm1hbCBzZW5zb3IgKFRTQURDKSBmb3IgYWxsIGJvYXJkcwo+ ID4+IHRoYXQgZG9uJ3QgY3VycmVudGx5IGhhdmUgaXQgZW5hYmxlZCwgdXNpbmcgdGhlIGRlZmF1 bHQgQ1JVIGJhc2VkCj4gPj4gZW1lcmdlbmN5IHRoZXJtYWwgcmVzZXQuIFRoaXMgZGVmYXVsdCBj b25maWd1cmF0aW9uIG9ubHkgdXNlcyBvbi1Tb0MKPiA+PiBkZXZpY2VzIGFuZCBkb2Vzbid0IHJl bHkgb24gYW55IGV4dGVybmFsIHdpcmluZywgdGh1cyBpdCBzaG91bGQgd29yawo+ID4+IGZvciBh bGwgZGV2aWNlcyAodGVzdGVkIG9ubHkgb24gUm9jayA1QiB0aG91Z2gpLgo+ID4+IAo+ID4+IFRo ZSBib2FyZHMgdGhhdCBoYXZlIFRTQURDX1NIVVQgc2lnbmFsIHdpcmVkIHRvIHRoZSBQTUlDIHJl c2V0IGxpbmUKPiA+PiBjYW4gY2hvb3NlIHRvIG92ZXJyaWRlIHRoZSBkZWZhdWx0IHJlc2V0IGxv Z2ljIGluIGZhdm91ciBvZiBHUElPCj4gPj4gZHJpdmVuIChQTUlDIGFzc2lzdGVkKSByZXNldCwg YnV0IGluIG15IHRlc3RpbmcgaXQgZGlkbid0IHdvcmsgb24KPiA+PiBSYWR4YSBSb2NrIDVCIC0g bWF5YmUgSSdtIHJlYWRpbmcgdGhlIHNjaGVtYXRpYyB3cm9uZyBhbmQgaXQgZG9lc24ndAo+ID4+ IHN1cHBvcnQgUE1JQyBhc3Npc3RlZCByZXNldCBhZnRlciBhbGwuCj4gPj4gCj4gPj4gRmFuIGNv bnRyb2wgb24gUm9jayA1QiBoYXMgYmVlbiBzcGxpdCBpbnRvIHR3byBpbnRlcnZhbHM6IGxldCBp dCBzcGluCj4gPj4gYXQgdGhlIG1pbmltdW0gY29vbGluZyBzdGF0ZSBiZXR3ZWVuIDU1QyBhbmQg NjVDLCBhbmQgdGhlbiBhY2NlbGVyYXRlCj4gPj4gaWYgdGhlIHN5c3RlbSBjcm9zc2VzIHRoZSA2 NUMgbWFyayAtIHRoYW5rcyB0byBEcmFnYW4gZm9yIHN1Z2dlc3RpbmcuCj4gPj4gVGhpcyBsZXRz IHNvbWUgY29vbGluZyBzZXR1cHMgd2l0aCBiZWVmaWVyIGhlYXRzaW5rcyBhbmQvb3IgbGFyZ2Vy Cj4gPj4gZmFuIGZpbnMgdG8gc3RheSBpbiB0aGUgcXVpZXRlc3Qgbm9uLXplcm8gZmFuIHN0YXRl IHdoaWxlIHN0aWxsCj4gPj4gZ2FpbmluZyBwb3RlbnRpYWwgYmVuZWZpdHMgZnJvbSB0aGUgYWly ZmxvdyBpdCBnZW5lcmF0ZXMsIGFuZAo+ID4+IHBvc3NpYmx5IGF2b2lkaW5nIG5vaXN5IHNwZWVk cyBhbHRvZ2V0aGVyIGZvciBzb21lIHdvcmtsb2Fkcy4KPiA+PiAKPiA+PiBPUFBzIGhlbHAgYWN0 dWFsbHkgc2NhbGUgQ1BVIGZyZXF1ZW5jaWVzIHVwIGFuZCBkb3duIGZvciBib3RoIGNvb2xpbmcK PiA+PiBhbmQgcGVyZm9ybWFuY2UgLSB0ZXN0ZWQgb24gUm9jayA1QiB1bmRlciB2YXJpZWQgbG9h ZHMuIEkndmUgZHJvcHBlZAo+ID4+IHRob3NlIE9QUHMgdGhhdCBjYXVzZSBmcmVxdWVuY3kgcmVk dWN0aW9ucyB3aXRob3V0IGFjY29tcGFueWluZyAKPiA+PiBkZWNyZWFzZQo+ID4+IGluIENQVSB2 b2x0YWdlLCBhcyB0aGV5IGRvbid0IHNlZW0gdG8gYmUgYWRkaW5nIG11Y2ggYmVuZWZpdCBpbiBk YXkgdG8KPiA+PiBkYXkgdXNlLCB3aGlsZSB0aGUga2VybmVsIGxvZyBnZXRzIGEgbnVtYmVyIG9m ICJPUFAgaXMgaW5lZmZpY2llbnQiIAo+ID4+IGxpbmVzLgo+ID4+IAo+ID4+IE5vdGUgdGhhdCB0 aGlzIHN1Ym1pc3Npb24gZG9lc24ndCB0b3VjaCB0aGUgU1JBTSByZWFkIG1hcmdpbiB1cGRhdGVz IAo+ID4+IG9yCj4gPj4gdGhlIE9QUCBjYWxpYnJhdGlvbiBiYXNlZCBvbiBzaWxpY29uIHF1YWxp dHkgd2hpY2ggdGhlIGRvd25zdHJlYW0gCj4gPj4gZHJpdmVyCj4gPj4gZG9lcyBhbmQgd2hpY2gg d2VyZSBtZW50aW9uZWQgaW4gWzFdLiBJdCB3b3JrcyBhcyBpdCBpcyAoYWxzbyAKPiA+PiBjb25m aXJtZWQgYnkKPiA+PiBTZWJhc3RpYW4gaW4gaGlzIGZvbGxvdy11cCBtZXNzYWdlIFsyXSksIGFu ZCBpdCBpcyBzdGFibGUgaW4gbXkgCj4gPj4gdGVzdGluZyBvbgo+ID4+IFJvY2sgNUIsIHNvIGl0 IHNvdW5kcyBiZXR0ZXIgdG8gbWVyZ2UgYSBzaW1wbGUgdmVyc2lvbiBmaXJzdCBhbmQgdGhlbgo+ ID4+IGV4dGVuZCB3aGVuL2lmIHJlcXVpcmVkLgo+ID4+IAo+ID4+IFsxXSAKPiA+PiBodHRwczov L2xvcmUua2VybmVsLm9yZy9saW51eC1yb2NrY2hpcC9DQUJqZDRZelRMPTVTN2NTOEFDTkFZVmE3 MzBXQTNpR2Q1TF93UDFWbjk9ZjgzUkNPUkFAbWFpbC5nbWFpbC5jb20vCj4gPj4gWzJdIAo+ID4+ IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2xpbnV4LXJvY2tjaGlwL3BreW5lNGcyY2xuMjdkY2R1 M2ptN2JxZHFwbWQya3drYmd1aW9sbW96bnRqdWlhanJiQGd2cTRudXB6bmE0by8KPiA+PiAKPiA+ PiBTaWduZWQtb2ZmLWJ5OiBBbGV4ZXkgQ2hhcmtvdiA8YWxjaGFya0BnbWFpbC5jb20+Cj4gPj4g LS0tCj4gPiAKPiA+IEhpIEhlaWtvLAo+ID4gCj4gPiBEbyB5b3UgdGhpbmsgdGhpcyBjYW4gYmUg bWVyZ2VkIGZvciA2LjExPyBMb29rcyBsaWtlIHRoZXJlIGhhc24ndCBiZWVuCj4gPiBhbnkgbmV3 IGZlZWRiYWNrIGluIGEgd2hpbGUsIGFuZCBpdCB3b3VsZCBiZSBnb29kIHRvIGhhdmUgZnJlcXVl bmN5Cj4gPiBzY2FsaW5nIGluIHBsYWNlIGZvciBSSzM1ODguCj4gPiAKPiA+IFBsZWFzZSBsZXQg bWUga25vdyBpZiB5b3UgaGF2ZSBhbnkgcmVzZXJ2YXRpb25zIG9yIGlmIHdlIG5lZWQgYW55Cj4g PiBicm9hZGVyIGRpc2N1c3Npb24uCgpub3QgcmVhbGx5IHJlc2VydmF0aW9ucywgbW9yZSBsaWtl IHRoZXJlIHdhcyBzdGlsbCBkaXNjdXNzaW9uIGdvaW5nIG9uCmFyb3VuZCB0aGUgT1BQcy4gTWVh bndoaWxlIHdlIGhhZCBtb3JlIGRpc2N1c3Npb25zIHJlZ2FyZGluZyB0aGUgd2hvbGUKc3BlZWQg YmlubmluZyBSb2NrY2hpcCBzZWVtcyB0byBkbyBmb3IgcmszNTg4IHZhcmlhbnRzLgoKQW5kIHdh aXRpbmcgZm9yIHRoZSB0ZXN0aW5nIERyYWdhbiB3YW50ZWQgdG8gZG8gOy0pIC4KClNvIHRoaXMg c2hvdWxkIGRlZmluaXRseSBtYWtlIGl0IGludG8gNi4xMSB0aG91Z2gsIGFzIHRoZXJlIGlzIHN0 aWxsCmEgbG90IG9mIHRpbWUuCiAKCj4gQXMgSSBwcm9taXNlZCBlYXJsaWVyLCBJIHdhcyBnb2lu ZyB0byB0ZXN0IHRoaXMgcGF0Y2ggc2VyaWVzIGluIGRldGFpbC4KPiBBbGFzLCBJIGhhdmVuJ3Qg bWFuYWdlZCB0byBkbyB0aGF0IHlldCwgOi8gZHVlIHRvIG1hbnkgcmVhc29ucywgYnV0Cj4gSSBz dGlsbCByZW1haW4gZmlybWx5IGNvbW1pdHRlZCB0byBkb2luZyB0aGF0Lgo+IAo+IElzIC1yYzQg dGhlIGN1dG9mZiBmb3IgNi4xMT8gIElmIHNvLCB0aGVyZSdzIHN0aWxsIHRpbWUgYW5kIEknbGwg ZG8gbXkKPiBiZXN0IHRvIHRlc3QgYW5kIHJldmlldyB0aGVzZSBwYXRjaGVzIGFzIHNvb24gYXMg cG9zc2libGUuCgpBcyBlYXJseSBhcyBwb3NzaWJsZSwgdGhlIGhhcmQgY3V0b2ZmIHdvdWxkIGJl IC1yYzYgdGhvdWdoLgpJIGd1ZXNzIEknbGwganVzdCBzdGFydCBwaWNraW5nIHRoZSBlYXN5IHBh dGNoZXMgZnJvbSB0aGUgc2VyaWVzLgoKCkhlaWtvCgoKCgoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtcm9ja2NoaXAgbWFpbGluZyBsaXN0Ckxp bnV4LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yb2NrY2hpcAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 137DEC25B78 for ; Tue, 28 May 2024 14:34:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2q+i51c/XrbXJvic0IRAeQ4nNpENRhVkXyHUmyM0uUw=; b=eCZ1maFF9NOgIB MSGdvQ/ghcE+8aiuKj0pAHR3ZHd7di2yZ8DF0/wVGjFcDABpIoU+enutIHEtaq+nanoePA7VifC8P QbjUPzIHPO2oxo805RKTgM5lLLcCU+/Raidr0ZnKUlYnsbsj8/XKEfF1NkS/l3dGTrGNqewRulJCf odMIqOrY1pG/6RXA331gnYTX417dONDO/lsPRgFic1Mm2XfijF9HWyCgyPwK5fV9LzpKhK+yF2w9Y hR7oA52lG1mTgy8tuZbPq0KTN5QUK0EfFmlkrm4eZdX1CWCs694tLKwBE0BBrthVd16SrMydiBsDK WTp90YqniLxrkAIr0x9A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBxuO-000000012ho-2Tvn; Tue, 28 May 2024 14:34:36 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBxuM-000000012h6-0YK8; Tue, 28 May 2024 14:34:35 +0000 Received: from [213.70.33.226] (helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sBxuB-0004aE-9M; Tue, 28 May 2024 16:34:23 +0200 From: Heiko Stuebner To: Alexey Charkov , Dragan Simic , Quentin Schulz Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Daniel Lezcano , Viresh Kumar , Chen-Yu Tsai , Diederik de Haas , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 0/6] RK3588 and Rock 5B dts additions: thermal, OPP and fan Date: Tue, 28 May 2024 16:34:21 +0200 Message-ID: <5122636.irdbgypaU6@phil> In-Reply-To: References: <20240506-rk-dts-additions-v4-0-271023ddfd40@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240528_073434_199417_84A14FC4 X-CRM114-Status: GOOD ( 41.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgRHJhZ2FuLAoKQW0gRGllbnN0YWcsIDI4LiBNYWkgMjAyNCwgMTY6MDU6MDQgQ0VTVCBzY2hy aWViIERyYWdhbiBTaW1pYzoKPiBPbiAyMDI0LTA1LTI4IDExOjQ5LCBBbGV4ZXkgQ2hhcmtvdiB3 cm90ZToKPiA+IE9uIE1vbiwgTWF5IDYsIDIwMjQgYXQgMTozN+KAr1BNIEFsZXhleSBDaGFya292 IDxhbGNoYXJrQGdtYWlsLmNvbT4gCj4gPiB3cm90ZToKPiA+PiAKPiA+PiBUaGlzIGVuYWJsZXMg dGhlcm1hbCBtb25pdG9yaW5nIGFuZCBDUFUgRFZGUyBvbiBSSzM1ODgocyksIGFzIHdlbGwgYXMK PiA+PiBhY3RpdmUgY29vbGluZyBvbiBSYWR4YSBSb2NrIDVCIHZpYSB0aGUgcHJvdmlkZWQgUFdN IGZhbi4KPiA+PiAKPiA+PiBTb21lIFJLMzU4OCBib2FyZHMgdXNlIHNlcGFyYXRlIHJlZ3VsYXRv cnMgdG8gc3VwcGx5IENQVXMgYW5kIHRoZWlyCj4gPj4gcmVzcGVjdGl2ZSBtZW1vcnkgaW50ZXJm YWNlcywgc28gdGhpcyBpcyBoYW5kbGVkIGJ5IGNvdXBsaW5nIHRob3NlCj4gPj4gcmVndWxhdG9y cyBpbiBhZmZlY3RlZCBib2FyZHMnIGRldmljZSB0cmVlcyB0byBlbnN1cmUgdGhhdCB0aGVpcgo+ ID4+IHZvbHRhZ2UgaXMgYWRqdXN0ZWQgaW4gc3RlcC4KPiA+PiAKPiA+PiBUaGlzIGFsc28gZW5h YmxlcyB0aGUgYnVpbHQtaW4gdGhlcm1hbCBzZW5zb3IgKFRTQURDKSBmb3IgYWxsIGJvYXJkcwo+ ID4+IHRoYXQgZG9uJ3QgY3VycmVudGx5IGhhdmUgaXQgZW5hYmxlZCwgdXNpbmcgdGhlIGRlZmF1 bHQgQ1JVIGJhc2VkCj4gPj4gZW1lcmdlbmN5IHRoZXJtYWwgcmVzZXQuIFRoaXMgZGVmYXVsdCBj b25maWd1cmF0aW9uIG9ubHkgdXNlcyBvbi1Tb0MKPiA+PiBkZXZpY2VzIGFuZCBkb2Vzbid0IHJl bHkgb24gYW55IGV4dGVybmFsIHdpcmluZywgdGh1cyBpdCBzaG91bGQgd29yawo+ID4+IGZvciBh bGwgZGV2aWNlcyAodGVzdGVkIG9ubHkgb24gUm9jayA1QiB0aG91Z2gpLgo+ID4+IAo+ID4+IFRo ZSBib2FyZHMgdGhhdCBoYXZlIFRTQURDX1NIVVQgc2lnbmFsIHdpcmVkIHRvIHRoZSBQTUlDIHJl c2V0IGxpbmUKPiA+PiBjYW4gY2hvb3NlIHRvIG92ZXJyaWRlIHRoZSBkZWZhdWx0IHJlc2V0IGxv Z2ljIGluIGZhdm91ciBvZiBHUElPCj4gPj4gZHJpdmVuIChQTUlDIGFzc2lzdGVkKSByZXNldCwg YnV0IGluIG15IHRlc3RpbmcgaXQgZGlkbid0IHdvcmsgb24KPiA+PiBSYWR4YSBSb2NrIDVCIC0g bWF5YmUgSSdtIHJlYWRpbmcgdGhlIHNjaGVtYXRpYyB3cm9uZyBhbmQgaXQgZG9lc24ndAo+ID4+ IHN1cHBvcnQgUE1JQyBhc3Npc3RlZCByZXNldCBhZnRlciBhbGwuCj4gPj4gCj4gPj4gRmFuIGNv bnRyb2wgb24gUm9jayA1QiBoYXMgYmVlbiBzcGxpdCBpbnRvIHR3byBpbnRlcnZhbHM6IGxldCBp dCBzcGluCj4gPj4gYXQgdGhlIG1pbmltdW0gY29vbGluZyBzdGF0ZSBiZXR3ZWVuIDU1QyBhbmQg NjVDLCBhbmQgdGhlbiBhY2NlbGVyYXRlCj4gPj4gaWYgdGhlIHN5c3RlbSBjcm9zc2VzIHRoZSA2 NUMgbWFyayAtIHRoYW5rcyB0byBEcmFnYW4gZm9yIHN1Z2dlc3RpbmcuCj4gPj4gVGhpcyBsZXRz IHNvbWUgY29vbGluZyBzZXR1cHMgd2l0aCBiZWVmaWVyIGhlYXRzaW5rcyBhbmQvb3IgbGFyZ2Vy Cj4gPj4gZmFuIGZpbnMgdG8gc3RheSBpbiB0aGUgcXVpZXRlc3Qgbm9uLXplcm8gZmFuIHN0YXRl IHdoaWxlIHN0aWxsCj4gPj4gZ2FpbmluZyBwb3RlbnRpYWwgYmVuZWZpdHMgZnJvbSB0aGUgYWly ZmxvdyBpdCBnZW5lcmF0ZXMsIGFuZAo+ID4+IHBvc3NpYmx5IGF2b2lkaW5nIG5vaXN5IHNwZWVk cyBhbHRvZ2V0aGVyIGZvciBzb21lIHdvcmtsb2Fkcy4KPiA+PiAKPiA+PiBPUFBzIGhlbHAgYWN0 dWFsbHkgc2NhbGUgQ1BVIGZyZXF1ZW5jaWVzIHVwIGFuZCBkb3duIGZvciBib3RoIGNvb2xpbmcK PiA+PiBhbmQgcGVyZm9ybWFuY2UgLSB0ZXN0ZWQgb24gUm9jayA1QiB1bmRlciB2YXJpZWQgbG9h ZHMuIEkndmUgZHJvcHBlZAo+ID4+IHRob3NlIE9QUHMgdGhhdCBjYXVzZSBmcmVxdWVuY3kgcmVk dWN0aW9ucyB3aXRob3V0IGFjY29tcGFueWluZyAKPiA+PiBkZWNyZWFzZQo+ID4+IGluIENQVSB2 b2x0YWdlLCBhcyB0aGV5IGRvbid0IHNlZW0gdG8gYmUgYWRkaW5nIG11Y2ggYmVuZWZpdCBpbiBk YXkgdG8KPiA+PiBkYXkgdXNlLCB3aGlsZSB0aGUga2VybmVsIGxvZyBnZXRzIGEgbnVtYmVyIG9m ICJPUFAgaXMgaW5lZmZpY2llbnQiIAo+ID4+IGxpbmVzLgo+ID4+IAo+ID4+IE5vdGUgdGhhdCB0 aGlzIHN1Ym1pc3Npb24gZG9lc24ndCB0b3VjaCB0aGUgU1JBTSByZWFkIG1hcmdpbiB1cGRhdGVz IAo+ID4+IG9yCj4gPj4gdGhlIE9QUCBjYWxpYnJhdGlvbiBiYXNlZCBvbiBzaWxpY29uIHF1YWxp dHkgd2hpY2ggdGhlIGRvd25zdHJlYW0gCj4gPj4gZHJpdmVyCj4gPj4gZG9lcyBhbmQgd2hpY2gg d2VyZSBtZW50aW9uZWQgaW4gWzFdLiBJdCB3b3JrcyBhcyBpdCBpcyAoYWxzbyAKPiA+PiBjb25m aXJtZWQgYnkKPiA+PiBTZWJhc3RpYW4gaW4gaGlzIGZvbGxvdy11cCBtZXNzYWdlIFsyXSksIGFu ZCBpdCBpcyBzdGFibGUgaW4gbXkgCj4gPj4gdGVzdGluZyBvbgo+ID4+IFJvY2sgNUIsIHNvIGl0 IHNvdW5kcyBiZXR0ZXIgdG8gbWVyZ2UgYSBzaW1wbGUgdmVyc2lvbiBmaXJzdCBhbmQgdGhlbgo+ ID4+IGV4dGVuZCB3aGVuL2lmIHJlcXVpcmVkLgo+ID4+IAo+ID4+IFsxXSAKPiA+PiBodHRwczov L2xvcmUua2VybmVsLm9yZy9saW51eC1yb2NrY2hpcC9DQUJqZDRZelRMPTVTN2NTOEFDTkFZVmE3 MzBXQTNpR2Q1TF93UDFWbjk9ZjgzUkNPUkFAbWFpbC5nbWFpbC5jb20vCj4gPj4gWzJdIAo+ID4+ IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2xpbnV4LXJvY2tjaGlwL3BreW5lNGcyY2xuMjdkY2R1 M2ptN2JxZHFwbWQya3drYmd1aW9sbW96bnRqdWlhanJiQGd2cTRudXB6bmE0by8KPiA+PiAKPiA+ PiBTaWduZWQtb2ZmLWJ5OiBBbGV4ZXkgQ2hhcmtvdiA8YWxjaGFya0BnbWFpbC5jb20+Cj4gPj4g LS0tCj4gPiAKPiA+IEhpIEhlaWtvLAo+ID4gCj4gPiBEbyB5b3UgdGhpbmsgdGhpcyBjYW4gYmUg bWVyZ2VkIGZvciA2LjExPyBMb29rcyBsaWtlIHRoZXJlIGhhc24ndCBiZWVuCj4gPiBhbnkgbmV3 IGZlZWRiYWNrIGluIGEgd2hpbGUsIGFuZCBpdCB3b3VsZCBiZSBnb29kIHRvIGhhdmUgZnJlcXVl bmN5Cj4gPiBzY2FsaW5nIGluIHBsYWNlIGZvciBSSzM1ODguCj4gPiAKPiA+IFBsZWFzZSBsZXQg bWUga25vdyBpZiB5b3UgaGF2ZSBhbnkgcmVzZXJ2YXRpb25zIG9yIGlmIHdlIG5lZWQgYW55Cj4g PiBicm9hZGVyIGRpc2N1c3Npb24uCgpub3QgcmVhbGx5IHJlc2VydmF0aW9ucywgbW9yZSBsaWtl IHRoZXJlIHdhcyBzdGlsbCBkaXNjdXNzaW9uIGdvaW5nIG9uCmFyb3VuZCB0aGUgT1BQcy4gTWVh bndoaWxlIHdlIGhhZCBtb3JlIGRpc2N1c3Npb25zIHJlZ2FyZGluZyB0aGUgd2hvbGUKc3BlZWQg YmlubmluZyBSb2NrY2hpcCBzZWVtcyB0byBkbyBmb3IgcmszNTg4IHZhcmlhbnRzLgoKQW5kIHdh aXRpbmcgZm9yIHRoZSB0ZXN0aW5nIERyYWdhbiB3YW50ZWQgdG8gZG8gOy0pIC4KClNvIHRoaXMg c2hvdWxkIGRlZmluaXRseSBtYWtlIGl0IGludG8gNi4xMSB0aG91Z2gsIGFzIHRoZXJlIGlzIHN0 aWxsCmEgbG90IG9mIHRpbWUuCiAKCj4gQXMgSSBwcm9taXNlZCBlYXJsaWVyLCBJIHdhcyBnb2lu ZyB0byB0ZXN0IHRoaXMgcGF0Y2ggc2VyaWVzIGluIGRldGFpbC4KPiBBbGFzLCBJIGhhdmVuJ3Qg bWFuYWdlZCB0byBkbyB0aGF0IHlldCwgOi8gZHVlIHRvIG1hbnkgcmVhc29ucywgYnV0Cj4gSSBz dGlsbCByZW1haW4gZmlybWx5IGNvbW1pdHRlZCB0byBkb2luZyB0aGF0Lgo+IAo+IElzIC1yYzQg dGhlIGN1dG9mZiBmb3IgNi4xMT8gIElmIHNvLCB0aGVyZSdzIHN0aWxsIHRpbWUgYW5kIEknbGwg ZG8gbXkKPiBiZXN0IHRvIHRlc3QgYW5kIHJldmlldyB0aGVzZSBwYXRjaGVzIGFzIHNvb24gYXMg cG9zc2libGUuCgpBcyBlYXJseSBhcyBwb3NzaWJsZSwgdGhlIGhhcmQgY3V0b2ZmIHdvdWxkIGJl IC1yYzYgdGhvdWdoLgpJIGd1ZXNzIEknbGwganVzdCBzdGFydCBwaWNraW5nIHRoZSBlYXN5IHBh dGNoZXMgZnJvbSB0aGUgc2VyaWVzLgoKCkhlaWtvCgoKCgoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QK bGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 763261DFDE; Tue, 28 May 2024 14:34:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.11.138.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716906877; cv=none; b=Mn1ir0LQfrz43hA1Dqq+VfL7EvxV5SKsAK8VDD5A0U06m1Heg8vlwL6GaoCvZqi/VEDojAUp0Qbr9qViu8iSrpo8ntS/bmQnXNg7qHMUEJioxa62hENlyrvb6fsepkeILDFUgjpdnJ1HWSZiEKWA25iXJH8q2bTDNnRqDGtO7vY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716906877; c=relaxed/simple; bh=QbezeNKJyW6qf2V3kTpxOxe+UTcg7sBnxBqrvnatxGw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rdZLyI11+YDpWTAtvReBM/ceHHNiWV9A6nM9zn28HiHvTHikdSziFruSKSyEtbgoBMTGEYmNR8eUH7+pLEdPqKBCBFJ7PSTWgvA903P0F6QOkaTKYkUJVlB46PY2/uSL8l6OVClXWWlkDts50NWdd+z/1aeISy4L6WWAGHhOiyY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; arc=none smtp.client-ip=185.11.138.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Received: from [213.70.33.226] (helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sBxuB-0004aE-9M; Tue, 28 May 2024 16:34:23 +0200 From: Heiko Stuebner To: Alexey Charkov , Dragan Simic , Quentin Schulz Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Daniel Lezcano , Viresh Kumar , Chen-Yu Tsai , Diederik de Haas , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 0/6] RK3588 and Rock 5B dts additions: thermal, OPP and fan Date: Tue, 28 May 2024 16:34:21 +0200 Message-ID: <5122636.irdbgypaU6@phil> In-Reply-To: References: <20240506-rk-dts-additions-v4-0-271023ddfd40@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Hi Dragan, Am Dienstag, 28. Mai 2024, 16:05:04 CEST schrieb Dragan Simic: > On 2024-05-28 11:49, Alexey Charkov wrote: > > On Mon, May 6, 2024 at 1:37=E2=80=AFPM Alexey Charkov =20 > > wrote: > >>=20 > >> This enables thermal monitoring and CPU DVFS on RK3588(s), as well as > >> active cooling on Radxa Rock 5B via the provided PWM fan. > >>=20 > >> Some RK3588 boards use separate regulators to supply CPUs and their > >> respective memory interfaces, so this is handled by coupling those > >> regulators in affected boards' device trees to ensure that their > >> voltage is adjusted in step. > >>=20 > >> This also enables the built-in thermal sensor (TSADC) for all boards > >> that don't currently have it enabled, using the default CRU based > >> emergency thermal reset. This default configuration only uses on-SoC > >> devices and doesn't rely on any external wiring, thus it should work > >> for all devices (tested only on Rock 5B though). > >>=20 > >> The boards that have TSADC_SHUT signal wired to the PMIC reset line > >> can choose to override the default reset logic in favour of GPIO > >> driven (PMIC assisted) reset, but in my testing it didn't work on > >> Radxa Rock 5B - maybe I'm reading the schematic wrong and it doesn't > >> support PMIC assisted reset after all. > >>=20 > >> Fan control on Rock 5B has been split into two intervals: let it spin > >> at the minimum cooling state between 55C and 65C, and then accelerate > >> if the system crosses the 65C mark - thanks to Dragan for suggesting. > >> This lets some cooling setups with beefier heatsinks and/or larger > >> fan fins to stay in the quietest non-zero fan state while still > >> gaining potential benefits from the airflow it generates, and > >> possibly avoiding noisy speeds altogether for some workloads. > >>=20 > >> OPPs help actually scale CPU frequencies up and down for both cooling > >> and performance - tested on Rock 5B under varied loads. I've dropped > >> those OPPs that cause frequency reductions without accompanying=20 > >> decrease > >> in CPU voltage, as they don't seem to be adding much benefit in day to > >> day use, while the kernel log gets a number of "OPP is inefficient"=20 > >> lines. > >>=20 > >> Note that this submission doesn't touch the SRAM read margin updates=20 > >> or > >> the OPP calibration based on silicon quality which the downstream=20 > >> driver > >> does and which were mentioned in [1]. It works as it is (also=20 > >> confirmed by > >> Sebastian in his follow-up message [2]), and it is stable in my=20 > >> testing on > >> Rock 5B, so it sounds better to merge a simple version first and then > >> extend when/if required. > >>=20 > >> [1]=20 > >> https://lore.kernel.org/linux-rockchip/CABjd4YzTL=3D5S7cS8ACNAYVa730WA= 3iGd5L_wP1Vn9=3Df83RCORA@mail.gmail.com/ > >> [2]=20 > >> https://lore.kernel.org/linux-rockchip/pkyne4g2cln27dcdu3jm7bqdqpmd2kw= kbguiolmozntjuiajrb@gvq4nupzna4o/ > >>=20 > >> Signed-off-by: Alexey Charkov > >> --- > >=20 > > Hi Heiko, > >=20 > > Do you think this can be merged for 6.11? Looks like there hasn't been > > any new feedback in a while, and it would be good to have frequency > > scaling in place for RK3588. > >=20 > > Please let me know if you have any reservations or if we need any > > broader discussion. not really reservations, more like there was still discussion going on around the OPPs. Meanwhile we had more discussions regarding the whole speed binning Rockchip seems to do for rk3588 variants. And waiting for the testing Dragan wanted to do ;-) . So this should definitly make it into 6.11 though, as there is still a lot of time. =20 > As I promised earlier, I was going to test this patch series in detail. > Alas, I haven't managed to do that yet, :/ due to many reasons, but > I still remain firmly committed to doing that. >=20 > Is -rc4 the cutoff for 6.11? If so, there's still time and I'll do my > best to test and review these patches as soon as possible. As early as possible, the hard cutoff would be -rc6 though. I guess I'll just start picking the easy patches from the series. Heiko