All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Marc Kleine-Budde <mkl@pengutronix.de>,
	Yegor Yefremov <yegorslists@googlemail.com>
Cc: "linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
	Michal Sojka <sojkam1@fel.cvut.cz>
Subject: Re: [PATCH] can-utils: AOSP build improvements
Date: Mon, 18 Feb 2013 22:56:19 +0100	[thread overview]
Message-ID: <5122A383.7040804@hartkopp.net> (raw)
In-Reply-To: <5121F27F.9020102@pengutronix.de>

On 18.02.2013 10:21, Marc Kleine-Budde wrote:

> On 02/18/2013 10:10 AM, Yegor Yefremov wrote:


>>
>> Btw what about isotp.h? Is it going to be mainlined?
> 
> That's Oliver's cup of tea :)


Hm - yes :-)

Of course it is going to be mainlined.

The code itself is working properly for a long time now. The only missing
point is that i do not have a really good idea how to cope with the fact that
up to 500 CAN frames can be pushed into the CAN netdev tx queue at a time.

The advisory to increase the tx_queue_len to 1000 is not a solution.

Maybe qdiscs is a solution or we need to be able to peek the tx queue state
whether we can push the next CAN frame to the device, or if we need to wait.

Once there is a good solution for that, it should be easy to make isotp fit
for mainline inclusion.

Regards,
Oliver


  reply	other threads:[~2013-02-18 21:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-18  8:06 [PATCH] can-utils: AOSP build improvements yegorslists
2013-02-18  8:15 ` Marc Kleine-Budde
2013-02-18  9:10   ` Yegor Yefremov
2013-02-18  9:21     ` Marc Kleine-Budde
2013-02-18 21:56       ` Oliver Hartkopp [this message]
2013-02-20  8:43         ` Kurt Van Dijck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5122A383.7040804@hartkopp.net \
    --to=socketcan@hartkopp.net \
    --cc=linux-can@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=sojkam1@fel.cvut.cz \
    --cc=yegorslists@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.