From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: [PATCH 1/2] ARM: dts: OMAP3: Add GPMC controller Date: Mon, 18 Feb 2013 19:00:21 -0600 Message-ID: <5122CEA5.5010902@ti.com> References: <1359395648-2137-1-git-send-email-florian.vaussard@epfl.ch> <1359395648-2137-2-git-send-email-florian.vaussard@epfl.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from arroyo.ext.ti.com ([192.94.94.40]:49628 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754499Ab3BSBAc (ORCPT ); Mon, 18 Feb 2013 20:00:32 -0500 In-Reply-To: <1359395648-2137-2-git-send-email-florian.vaussard@epfl.ch> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Florian Vaussard Cc: Benoit Cousson , Tony Lindgren , Daniel Mack , linux-omap@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org On 01/28/2013 11:54 AM, Florian Vaussard wrote: > Add device-tree support for the GPMC controller on the OMAP3. > > Signed-off-by: Florian Vaussard > --- > arch/arm/boot/dts/omap3.dtsi | 11 +++++++++++ > 1 files changed, 11 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi > index 6c63118..2ddae38 100644 > --- a/arch/arm/boot/dts/omap3.dtsi > +++ b/arch/arm/boot/dts/omap3.dtsi > @@ -403,5 +403,16 @@ > ti,timer-alwon; > ti,timer-secure; > }; > + > + gpmc: gpmc@6e000000 { > + compatible = "ti,omap3430-gpmc"; > + ti,hwmods = "gpmc"; > + reg = <0x6e000000 0x1000000>; Can you make this size smaller? Although the reference manual states 16MB, the registers use less than 1KB of address space. Hence, it is pointless mapping all this address space for the gpmc registers. > + interrupts = <20>; > + gpmc,num-cs = <8>; > + gpmc,num-waitpins = <4>; > + #address-cells = <2>; > + #size-cells = <1>; > + }; > }; > }; Otherwise ... Reviewed-by: Jon Hunter Cheers Jon From mboxrd@z Thu Jan 1 00:00:00 1970 From: jon-hunter@ti.com (Jon Hunter) Date: Mon, 18 Feb 2013 19:00:21 -0600 Subject: [PATCH 1/2] ARM: dts: OMAP3: Add GPMC controller In-Reply-To: <1359395648-2137-2-git-send-email-florian.vaussard@epfl.ch> References: <1359395648-2137-1-git-send-email-florian.vaussard@epfl.ch> <1359395648-2137-2-git-send-email-florian.vaussard@epfl.ch> Message-ID: <5122CEA5.5010902@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 01/28/2013 11:54 AM, Florian Vaussard wrote: > Add device-tree support for the GPMC controller on the OMAP3. > > Signed-off-by: Florian Vaussard > --- > arch/arm/boot/dts/omap3.dtsi | 11 +++++++++++ > 1 files changed, 11 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi > index 6c63118..2ddae38 100644 > --- a/arch/arm/boot/dts/omap3.dtsi > +++ b/arch/arm/boot/dts/omap3.dtsi > @@ -403,5 +403,16 @@ > ti,timer-alwon; > ti,timer-secure; > }; > + > + gpmc: gpmc at 6e000000 { > + compatible = "ti,omap3430-gpmc"; > + ti,hwmods = "gpmc"; > + reg = <0x6e000000 0x1000000>; Can you make this size smaller? Although the reference manual states 16MB, the registers use less than 1KB of address space. Hence, it is pointless mapping all this address space for the gpmc registers. > + interrupts = <20>; > + gpmc,num-cs = <8>; > + gpmc,num-waitpins = <4>; > + #address-cells = <2>; > + #size-cells = <1>; > + }; > }; > }; Otherwise ... Reviewed-by: Jon Hunter Cheers Jon