From: "Javier Muñoz" <jmunhoz@igalia.com>
To: Peter Huewe <peterhuewe@gmx.de>
Cc: Teddy Wang <teddy.wang@siliconmotion.com.cn>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Devendra Naga <devendra.aaru@gmail.com>,
Bill Pemberton <wfp5p@virginia.edu>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging/sm7xxfb: Convert to SIMPLE_DEV_PM_OPS
Date: Tue, 19 Feb 2013 04:01:10 +0100 [thread overview]
Message-ID: <5122EAF6.9040302@igalia.com> (raw)
In-Reply-To: <1361229168-18137-1-git-send-email-peterhuewe@gmx.de>
Thanks!
Acked-by: Javier Muñoz <jmunhoz@igalia.com>
On 02/19/2013 12:12 AM, Peter Huewe wrote:
> Instead of assigning the pm_ops fields individually we can simply use
> SIMPLE_DEV_PM_OPS.
>
> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
> ---
> drivers/staging/sm7xxfb/sm7xxfb.c | 10 +---------
> 1 files changed, 1 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c b/drivers/staging/sm7xxfb/sm7xxfb.c
> index 0764bbb..8add64b 100644
> --- a/drivers/staging/sm7xxfb/sm7xxfb.c
> +++ b/drivers/staging/sm7xxfb/sm7xxfb.c
> @@ -1006,15 +1006,7 @@ static int smtcfb_pci_resume(struct device *device)
> return 0;
> }
>
> -static const struct dev_pm_ops sm7xx_pm_ops = {
> - .suspend = smtcfb_pci_suspend,
> - .resume = smtcfb_pci_resume,
> - .freeze = smtcfb_pci_suspend,
> - .thaw = smtcfb_pci_resume,
> - .poweroff = smtcfb_pci_suspend,
> - .restore = smtcfb_pci_resume,
> -};
> -
> +static SIMPLE_DEV_PM_OPS(sm7xx_pm_ops, smtcfb_pci_suspend, smtcfb_pci_resume);
> #define SM7XX_PM_OPS (&sm7xx_pm_ops)
>
> #else /* !CONFIG_PM */
prev parent reply other threads:[~2013-02-19 3:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-18 23:12 [PATCH] staging/sm7xxfb: Convert to SIMPLE_DEV_PM_OPS Peter Huewe
2013-02-19 3:01 ` Javier Muñoz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5122EAF6.9040302@igalia.com \
--to=jmunhoz@igalia.com \
--cc=devel@driverdev.osuosl.org \
--cc=devendra.aaru@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=teddy.wang@siliconmotion.com.cn \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.