All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tang Chen <tangchen@cn.fujitsu.com>
To: Shaohua Li <shli@kernel.org>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [bug]patch "acpi, memory-hotplug: parse SRAT before memblock is ready" breaks numa detection
Date: Tue, 19 Feb 2013 11:29:00 +0800	[thread overview]
Message-ID: <5122F17C.6020209@cn.fujitsu.com> (raw)
In-Reply-To: <20130219030752.GA30739@kernel.org>

On 02/19/2013 11:07 AM, Shaohua Li wrote:
> This patch in linux-next breaks numa detection. numa_init() will zero
> numa_meminfo. If acpi_numa_init() does not call early_parse_srat(), we will
> have no memory numa info.
>

Hum, yes, I missed this one. :)

Briefly seeing the code, I think moving the following code to 
early_parse_srat()
will fix it, right? :)

	memset(&numa_meminfo, 0, sizeof(numa_meminfo));

I'll send a patch to fix it.

Thanks. :)

      reply	other threads:[~2013-02-19  3:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-19  3:07 [bug]patch "acpi, memory-hotplug: parse SRAT before memblock is ready" breaks numa detection Shaohua Li
2013-02-19  3:29 ` Tang Chen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5122F17C.6020209@cn.fujitsu.com \
    --to=tangchen@cn.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shli@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.