From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Courbot Subject: Re: [RFC PATCH 4/9] hwmon: (lm90) use macros for the indexes of temp8 and temp11 Date: Tue, 19 Feb 2013 14:39:22 +0900 Message-ID: <5123100A.9050604@nvidia.com> References: <1361187031-3679-1-git-send-email-wni@nvidia.com> <1361187031-3679-5-git-send-email-wni@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from hqemgate03.nvidia.com ([216.228.121.140]:4037 "EHLO hqemgate03.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753432Ab3BSFj2 (ORCPT ); Tue, 19 Feb 2013 00:39:28 -0500 In-Reply-To: <1361187031-3679-5-git-send-email-wni@nvidia.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Wei Ni Cc: "durgadoss.r@intel.com" , "rui.zhang@intel.com" , Matthew Longnecker , "khali@linux-fr.org" , "devicetree-discuss@lists.ozlabs.org" , "linux-tegra@vger.kernel.org" , "lm-sensors@lm-sensors.org" , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.orgrs.org" , "linux-arm-kernel@lists.infradead.org" On 02/18/2013 08:30 PM, Wei Ni wrote: > Using macros for the indexes and nrs of temp8 and temp11. > This make the code much clearer. > > Signed-off-by: Wei Ni Acked-by: Alexandre Courbot Great patch. This makes the code much more readable. I also compiled lm90.o before and after this patch, and diff'ed the stripped binaries to make sure there was no error in the macro indexes. Both binaries were indentical, therefore: Tested-by: Alexandre Courbot Alex. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Courbot Date: Tue, 19 Feb 2013 05:39:22 +0000 Subject: Re: [lm-sensors] [RFC PATCH 4/9] hwmon: (lm90) use macros for the indexes of temp8 and temp11 Message-Id: <5123100A.9050604@nvidia.com> List-Id: References: <1361187031-3679-1-git-send-email-wni@nvidia.com> <1361187031-3679-5-git-send-email-wni@nvidia.com> In-Reply-To: <1361187031-3679-5-git-send-email-wni@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Wei Ni Cc: "durgadoss.r@intel.com" , "rui.zhang@intel.com" , Matthew Longnecker , "khali@linux-fr.org" , "devicetree-discuss@lists.ozlabs.org" , "linux-tegra@vger.kernel.org" , "lm-sensors@lm-sensors.org" , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.orgrs.org" , "linux-arm-kernel@lists.infradead.org" On 02/18/2013 08:30 PM, Wei Ni wrote: > Using macros for the indexes and nrs of temp8 and temp11. > This make the code much clearer. > > Signed-off-by: Wei Ni Acked-by: Alexandre Courbot Great patch. This makes the code much more readable. I also compiled lm90.o before and after this patch, and diff'ed the stripped binaries to make sure there was no error in the macro indexes. Both binaries were indentical, therefore: Tested-by: Alexandre Courbot Alex. _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors From mboxrd@z Thu Jan 1 00:00:00 1970 From: acourbot@nvidia.com (Alex Courbot) Date: Tue, 19 Feb 2013 14:39:22 +0900 Subject: [RFC PATCH 4/9] hwmon: (lm90) use macros for the indexes of temp8 and temp11 In-Reply-To: <1361187031-3679-5-git-send-email-wni@nvidia.com> References: <1361187031-3679-1-git-send-email-wni@nvidia.com> <1361187031-3679-5-git-send-email-wni@nvidia.com> Message-ID: <5123100A.9050604@nvidia.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/18/2013 08:30 PM, Wei Ni wrote: > Using macros for the indexes and nrs of temp8 and temp11. > This make the code much clearer. > > Signed-off-by: Wei Ni Acked-by: Alexandre Courbot Great patch. This makes the code much more readable. I also compiled lm90.o before and after this patch, and diff'ed the stripped binaries to make sure there was no error in the macro indexes. Both binaries were indentical, therefore: Tested-by: Alexandre Courbot Alex.