From: Bart Van Assche <bvanassche@acm.org>
To: Rob Evers <revers@redhat.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH v2 1/3] Encapsulate scsi_do_report_luns
Date: Tue, 19 Feb 2013 08:15:01 +0100 [thread overview]
Message-ID: <51232675.4090104@acm.org> (raw)
In-Reply-To: <1361214952-28978-2-git-send-email-revers@redhat.com>
On 02/18/13 20:15, Rob Evers wrote:
> + /*
> + * bytes 6 - 9: length of the command.
> + */
> + scsi_cmd[6] = (unsigned char) (length >> 24) & 0xff;
> + scsi_cmd[7] = (unsigned char) (length >> 16) & 0xff;
> + scsi_cmd[8] = (unsigned char) (length >> 8) & 0xff;
> + scsi_cmd[9] = (unsigned char) length & 0xff;
Have you considered using put_unaligned_be32() here ?
Bart.
next prev parent reply other threads:[~2013-02-19 7:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-18 19:15 [PATCH v2 0/3] Configure number of LUs reported by 'report-luns' Rob Evers
2013-02-18 19:15 ` [PATCH v2 1/3] Encapsulate scsi_do_report_luns Rob Evers
2013-02-19 7:15 ` Bart Van Assche [this message]
2013-02-19 15:57 ` Rob Evers
2013-02-18 19:15 ` [PATCH v2 2/3] Configure reported luns Rob Evers
2013-02-19 7:17 ` Bart Van Assche
2013-02-18 19:15 ` [PATCH v2 3/3] Change kmallocs in report_luns to use GFP_KERNEL Rob Evers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51232675.4090104@acm.org \
--to=bvanassche@acm.org \
--cc=linux-scsi@vger.kernel.org \
--cc=revers@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.