From: rob.herring@calxeda.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] irqchip: fix typo when moving gic_raise_softirq()
Date: Tue, 19 Feb 2013 07:57:36 -0600 [thread overview]
Message-ID: <512384D0.1010306@calxeda.com> (raw)
In-Reply-To: <1361281942-16885-1-git-send-email-javi.merino@arm.com>
On 02/19/2013 07:52 AM, Javi Merino wrote:
> In b1cffebf (ARM: GIC: remove direct use of gic_raise_softirq)
> gic_raise_softirq() was moved inside arch/arm/common/gic.c but in the
> process it reverted by mistake a change to that function made by
> 384a290 (ARM: gic: use a private mapping for CPU target interfaces).
> This breaks multicluster systems on ARM.
>
> This patch fixes the typo.
>
> Cc: Olof Johansson <olof@lixom.net>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Signed-off-by: Javi Merino <javi.merino@arm.com>
I wouldn't really call this a typo, but a rebasing error. Not really
important though, so:
Acked-by: Rob Herring <rob.herring@calxeda.com>
> ---
> drivers/irqchip/irq-gic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
> index 644d724..a32e0d5 100644
> --- a/drivers/irqchip/irq-gic.c
> +++ b/drivers/irqchip/irq-gic.c
> @@ -648,7 +648,7 @@ void gic_raise_softirq(const struct cpumask *mask, unsigned int irq)
>
> /* Convert our logical CPU mask into a physical one. */
> for_each_cpu(cpu, mask)
> - map |= 1 << cpu_logical_map(cpu);
> + map |= gic_cpu_map[cpu];
>
> /*
> * Ensure that stores to Normal memory are visible to the
>
next prev parent reply other threads:[~2013-02-19 13:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-19 13:52 [PATCH] irqchip: fix typo when moving gic_raise_softirq() Javi Merino
2013-02-19 13:57 ` Rob Herring [this message]
2013-02-26 7:05 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512384D0.1010306@calxeda.com \
--to=rob.herring@calxeda.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.