Re: [PATCH v2 1/3] Encapsulate scsi_do_report_luns

[Rob Evers <revers@redhat.com>]

On 02/19/2013 02:15 AM, Bart Van Assche wrote:
> On 02/18/13 20:15, Rob Evers wrote:
>> +    /*
>> +     * bytes 6 - 9: length of the command.
>> +     */
>> +    scsi_cmd[6] = (unsigned char) (length >> 24) & 0xff;
>> +    scsi_cmd[7] = (unsigned char) (length >> 16) & 0xff;
>> +    scsi_cmd[8] = (unsigned char) (length >> 8) & 0xff;
>> +    scsi_cmd[9] = (unsigned char) length & 0xff;
>
> Have you considered using put_unaligned_be32() here ?
>
> Bart.

Thanks for the suggestion Bart.

James,

Are you in favor of the type of change
Bart is suggesting?

I thought I saw some email a while back where
you disagreed with stylistic only changes to existing
code.  Is that true and does it apply here?

Rob