From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [RFC PATCH 3/9] hwmon: (lm90) add support to handle irq Date: Tue, 19 Feb 2013 16:00:05 -0700 Message-ID: <512403F5.5010005@wwwdotorg.org> References: <1361187031-3679-1-git-send-email-wni@nvidia.com> <1361187031-3679-4-git-send-email-wni@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from avon.wwwdotorg.org ([70.85.31.133]:58394 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933463Ab3BSXAJ (ORCPT ); Tue, 19 Feb 2013 18:00:09 -0500 In-Reply-To: <1361187031-3679-4-git-send-email-wni@nvidia.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Wei Ni Cc: durgadoss.r@intel.com, rui.zhang@intel.com, MLongnecker@nvidia.com, khali@linux-fr.org, devicetree-discuss@lists.ozlabs.org, linux-tegra@vger.kernel.org, lm-sensors@lm-sensors.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.orgrs.org, linux-arm-kernel@lists.infradead.org, Alexandre Courbot On 02/18/2013 04:30 AM, Wei Ni wrote: > Add support to handle irq. When the temperature touch the limit value, the > driver can handle the interrupt. > diff --git a/drivers/hwmon/lm90.c b/drivers/hwmon/lm90.c > +static void lm90_irq_work(struct work_struct *work) ... > + enable_irq(client->irq); > +} > + > +static irqreturn_t lm90_irq(int irq, void *dev_id) > +{ > + struct lm90_data *data = dev_id; > + > + disable_irq_nosync(irq); I think IRQF_ONESHOT would enable you to remove the manual enable/disable_irq calls. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Tue, 19 Feb 2013 23:00:05 +0000 Subject: Re: [lm-sensors] [RFC PATCH 3/9] hwmon: (lm90) add support to handle irq Message-Id: <512403F5.5010005@wwwdotorg.org> List-Id: References: <1361187031-3679-1-git-send-email-wni@nvidia.com> <1361187031-3679-4-git-send-email-wni@nvidia.com> In-Reply-To: <1361187031-3679-4-git-send-email-wni@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Wei Ni Cc: durgadoss.r@intel.com, rui.zhang@intel.com, MLongnecker@nvidia.com, khali@linux-fr.org, devicetree-discuss@lists.ozlabs.org, linux-tegra@vger.kernel.org, lm-sensors@lm-sensors.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.orgrs.org, linux-arm-kernel@lists.infradead.org, Alexandre Courbot On 02/18/2013 04:30 AM, Wei Ni wrote: > Add support to handle irq. When the temperature touch the limit value, the > driver can handle the interrupt. > diff --git a/drivers/hwmon/lm90.c b/drivers/hwmon/lm90.c > +static void lm90_irq_work(struct work_struct *work) ... > + enable_irq(client->irq); > +} > + > +static irqreturn_t lm90_irq(int irq, void *dev_id) > +{ > + struct lm90_data *data = dev_id; > + > + disable_irq_nosync(irq); I think IRQF_ONESHOT would enable you to remove the manual enable/disable_irq calls. _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors From mboxrd@z Thu Jan 1 00:00:00 1970 From: swarren@wwwdotorg.org (Stephen Warren) Date: Tue, 19 Feb 2013 16:00:05 -0700 Subject: [RFC PATCH 3/9] hwmon: (lm90) add support to handle irq In-Reply-To: <1361187031-3679-4-git-send-email-wni@nvidia.com> References: <1361187031-3679-1-git-send-email-wni@nvidia.com> <1361187031-3679-4-git-send-email-wni@nvidia.com> Message-ID: <512403F5.5010005@wwwdotorg.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/18/2013 04:30 AM, Wei Ni wrote: > Add support to handle irq. When the temperature touch the limit value, the > driver can handle the interrupt. > diff --git a/drivers/hwmon/lm90.c b/drivers/hwmon/lm90.c > +static void lm90_irq_work(struct work_struct *work) ... > + enable_irq(client->irq); > +} > + > +static irqreturn_t lm90_irq(int irq, void *dev_id) > +{ > + struct lm90_data *data = dev_id; > + > + disable_irq_nosync(irq); I think IRQF_ONESHOT would enable you to remove the manual enable/disable_irq calls.