From: ChenQi <Qi.Chen@windriver.com>
To: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
Cc: Zhenfeng.Zhao@windriver.com, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] hwclock.sh: check for the existence of /etc/default/rcS
Date: Wed, 20 Feb 2013 13:58:07 +0800 [thread overview]
Message-ID: <512465EF.6090501@windriver.com> (raw)
In-Reply-To: <CAC1BbcSiDGonDHWfKnjM47qFWwREzZ8Qjno4AW1z8MWJwFyW1g@mail.gmail.com>
On 02/19/2013 07:10 PM, Bernhard Reutner-Fischer wrote:
> On 19 February 2013 08:59, <Qi.Chen@windriver.com> wrote:
>> From: Chen Qi <Qi.Chen@windriver.com>
>>
>> /etc/default/rcS might be missing if the init manager is not sysvinit.
>> So we have to check for the existence of this file before sourcing it.
>>
>> [YOCTO #3697]
>>
>> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
>> ---
>> meta/recipes-core/busybox/files/hwclock.sh | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-core/busybox/files/hwclock.sh b/meta/recipes-core/busybox/files/hwclock.sh
>> index cc6d286..be5f94d 100644
>> --- a/meta/recipes-core/busybox/files/hwclock.sh
>> +++ b/meta/recipes-core/busybox/files/hwclock.sh
>> @@ -20,7 +20,7 @@
>>
>> [ ! -x /sbin/hwclock ] && exit 0
>>
>> -. /etc/default/rcS
>> +[ -f /etc/default/rcS ] && . /etc/default/rcS
> I'd make that -r fwiw.
>
>
Thank you for your review.
In this case, I think they have the same effect.
Best Regards,
Chen Qi
prev parent reply other threads:[~2013-02-20 6:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-19 7:59 [PATCH 0/1] hwclock.sh: check for the existence of /etc/default/rcS Qi.Chen
2013-02-19 7:59 ` [PATCH 1/1] " Qi.Chen
2013-02-19 11:10 ` Bernhard Reutner-Fischer
2013-02-20 5:58 ` ChenQi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512465EF.6090501@windriver.com \
--to=qi.chen@windriver.com \
--cc=Zhenfeng.Zhao@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=rep.dot.nop@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.