From: Gao feng <gaofeng@cn.fujitsu.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org,
containers@lists.linux-foundation.org, ebiederm@xmission.com,
netdev@vger.kernel.org, lve@guap.ru
Subject: Re: [PATCH 01/10] netfilter: make /proc/net/netfilter pernet
Date: Wed, 20 Feb 2013 14:36:26 +0800 [thread overview]
Message-ID: <51246EEA.5020301@cn.fujitsu.com> (raw)
In-Reply-To: <20130207183318.GA18359@localhost>
Hi Pablo,
On 2013/02/08 02:33, Pablo Neira Ayuso wrote:
> Hi Gao,
>
> Thanks again for improving netns support for netfilter. Comments
> below:
>
> On Thu, Feb 07, 2013 at 03:49:41PM +0800, Gao feng wrote:
>> Now,only init net has directroy /proc/net/netfilter,
>> this patch make this proc dentry pernet.
>>
>> Signed-off-by: Gao feng <gaofeng@cn.fujitsu.com>
>> ---
>> include/net/netns/x_tables.h | 3 +++
>> net/netfilter/core.c | 40 ++++++++++++++++++++++++++++++++++------
>> 2 files changed, 37 insertions(+), 6 deletions(-)
>>
>> diff --git a/include/net/netns/x_tables.h b/include/net/netns/x_tables.h
>> index c24060e..aa6a545 100644
>> --- a/include/net/netns/x_tables.h
>> +++ b/include/net/netns/x_tables.h
>> @@ -9,6 +9,9 @@ struct ebt_table;
>> struct netns_xt {
>> struct list_head tables[NFPROTO_NUMPROTO];
>> bool notrack_deprecated_warning;
>> +#if defined CONFIG_PROC_FS
>> + struct proc_dir_entry *proc_netfilter;
>> +#endif
>
> This doesn't belong here to x_tables, it should be place in
> include/net/net_namespace.h.
>
Get it,will fix it in next version.
Should I wait for the nf-next being open again?
next prev parent reply other threads:[~2013-02-20 6:36 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 7:49 [PATCH 01/10] netfilter: make /proc/net/netfilter pernet Gao feng
2013-02-07 7:49 ` [PATCH 03/10] netfilter: ebt_log: add net namespace support for ebt_log Gao feng
2013-02-07 7:49 ` [PATCH 06/10] netfilter: ipt_ulog: add net namespace support for ipt_ulog Gao feng
2013-02-07 7:57 ` Gao feng
[not found] ` <1360223390-15589-6-git-send-email-gaofeng-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2013-02-07 7:57 ` Gao feng
[not found] ` <1360223390-15589-1-git-send-email-gaofeng-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2013-02-07 7:49 ` [PATCH 02/10] netfilter: nf_log: prepar net namespace support for nf_log Gao feng
[not found] ` <1360223390-15589-2-git-send-email-gaofeng-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2013-02-07 18:39 ` Pablo Neira Ayuso
2013-11-05 14:14 ` Arnaldo Carvalho de Melo
[not found] ` <20131105141455.GB22912-f8uhVLnGfZaxAyOMLChx1axOck334EZe@public.gmane.org>
2013-11-06 2:00 ` Gao feng
2013-11-06 2:00 ` Gao feng
2013-02-07 7:49 ` [PATCH 03/10] netfilter: ebt_log: add net namespace support for ebt_log Gao feng
2013-02-07 7:49 ` [PATCH 04/10] netfilter: xt_LOG: add net namespace support for xt_LOG Gao feng
2013-02-07 7:49 ` [PATCH 05/10] netfilter: ebt_ulog: add net namesapce support for ebt_ulog Gao feng
2013-02-07 7:49 ` [PATCH 06/10] netfilter: ipt_ulog: add net namespace support for ipt_ulog Gao feng
2013-02-07 7:49 ` [PATCH 07/10] netfilter: nfnetlink_log: add net namespace support for nfnetlink_log Gao feng
2013-02-07 7:49 ` [PATCH 08/10] netfilter: nf_log: enable nflog in un-init net namespace Gao feng
2013-02-07 7:49 ` [PATCH 09/10] netfilter: nfnetlink_queue: add net namespace support for nfnetlink_queue Gao feng
2013-02-07 7:49 ` [PATCH 10/10] netfilter: remove useless variable proc_net_netfilter Gao feng
2013-02-07 18:33 ` [PATCH 01/10] netfilter: make /proc/net/netfilter pernet Pablo Neira Ayuso
2013-02-07 7:49 ` [PATCH 07/10] netfilter: nfnetlink_log: add net namespace support for nfnetlink_log Gao feng
2013-02-07 7:49 ` [PATCH 08/10] netfilter: nf_log: enable nflog in un-init net namespace Gao feng
2013-02-07 7:49 ` [PATCH 09/10] netfilter: nfnetlink_queue: add net namespace support for nfnetlink_queue Gao feng
2013-02-07 7:49 ` [PATCH 10/10] netfilter: remove useless variable proc_net_netfilter Gao feng
2013-02-07 18:33 ` [PATCH 01/10] netfilter: make /proc/net/netfilter pernet Pablo Neira Ayuso
2013-02-20 6:36 ` Gao feng
2013-02-20 6:36 ` Gao feng [this message]
2013-02-20 23:13 ` Pablo Neira Ayuso
[not found] ` <51246EEA.5020301-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2013-02-20 23:13 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51246EEA.5020301@cn.fujitsu.com \
--to=gaofeng@cn.fujitsu.com \
--cc=containers@lists.linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=lve@guap.ru \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.