From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] i.MX6: Add hdmidet command
Date: Wed, 20 Feb 2013 09:36:05 +0100 [thread overview]
Message-ID: <51248AF5.8070403@denx.de> (raw)
In-Reply-To: <51242523.7010403@boundarydevices.com>
On 20/02/2013 02:21, Eric Nelson wrote:
> On 02/19/2013 06:19 PM, Otavio Salvador wrote:
>> On Tue, Feb 19, 2013 at 10:16 PM, Eric Nelson
>> <eric.nelson@boundarydevices.com> wrote:
>>> On 02/19/2013 05:42 PM, Otavio Salvador wrote:
>>>>
>>>> On Tue, Feb 19, 2013 at 8:03 PM, Eric Nelson
>>>> <eric.nelson@boundarydevices.com> wrote:
>>>>>
>>>>> Hi Otavio,
>>>>>
>>>>>
>>>>> On 02/19/2013 01:30 PM, Otavio Salvador wrote:
>>>>>>
>>>>>>
>>>>>> On Tue, Feb 19, 2013 at 5:12 PM, Eric Nelson
>>>>>> <eric.nelson@boundarydevices.com> wrote:
>>>>>>>
>>>>>>>
>>>>>>> Hi Stefano,
>>>>>>>
>>>>>>> This seems to have gotten lost in the shuffle.
>>>>>>>
>>>>>>> It's showing as "Changes requested" in Patchwork:
>>>>>>>
>>>>>>> http://patchwork.ozlabs.org/patch/186280/
>>>>>>>
>>>>>>> Is there something you'd like changed?
>>>>>>>
>>>>>>> Please advise,
>>>>>>
>>>>>>
>>>>>>
>>>>>> I'd say to use space between the '+' as done in other code.
>>>>>>
>>>>>
>>>>> I must be dense.
>>>>>
>>>>> Which '+' needs a space?
>>>>
>>>>
>>>> It seems usually when dealing with offsets we have ' + '. Personally I
>>>> think it is clear to read too. But it's not my call so it is up to you
>>>> and Stefano.
>>>>
>>> Gotcha.
>>>
>>> You mean here:
>>>
>>> +{
>>> + u8 reg = __raw_readb(HDMI_ARB_BASE_ADDR+HDMI_PHY_STAT0);
>>> ^
>>>
>>> That's the trouble with commenting on the patchwork link...
>>
>> Yes; a space between both macros.
>>
>
> And a run through checkpatch...
>
> I am dense today.
>
Right, sorry for late answer - it is only to fix checkpatch warning,
nothing more. I wll then apply it
Best regards,
Stefano
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
prev parent reply other threads:[~2013-02-20 8:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-19 20:12 [U-Boot] i.MX6: Add hdmidet command Eric Nelson
2013-02-19 20:30 ` Otavio Salvador
2013-02-19 23:03 ` Eric Nelson
2013-02-20 0:42 ` Otavio Salvador
2013-02-20 1:16 ` Eric Nelson
2013-02-20 1:19 ` Otavio Salvador
2013-02-20 1:21 ` Eric Nelson
2013-02-20 8:36 ` Stefano Babic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51248AF5.8070403@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.