From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wanlong Gao Subject: Re: [PATCH 13/16] caif_virtio: use simplified virtqueue accessors. Date: Wed, 20 Feb 2013 18:13:12 +0800 Message-ID: <5124A1B8.7030102@cn.fujitsu.com> References: <1361260594-601-1-git-send-email-rusty@rustcorp.com.au> <1361260594-601-14-git-send-email-rusty@rustcorp.com.au> Reply-To: gaowanlong@cn.fujitsu.com Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1361260594-601-14-git-send-email-rusty@rustcorp.com.au> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Rusty Russell Cc: Paolo Bonzini , virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, "Michael S. Tsirkin" List-Id: virtualization@lists.linuxfoundation.org On 02/19/2013 03:56 PM, Rusty Russell wrote: > We never add buffers with input and output parts, so use the new accessors. > > Signed-off-by: Rusty Russell Reviewed-by: Wanlong Gao > --- > drivers/net/caif/caif_virtio.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/caif/caif_virtio.c b/drivers/net/caif/caif_virtio.c > index df832e7..9360055 100644 > --- a/drivers/net/caif/caif_virtio.c > +++ b/drivers/net/caif/caif_virtio.c > @@ -364,8 +364,7 @@ static int cfv_netdev_tx(struct sk_buff *skb, struct net_device *netdev) > /* Add buffer to avail ring. Flow control below should ensure > * that this always succeedes > */ > - ret = virtqueue_add_buf(cfv->vq_tx, &sg, 1, 0, > - buf_info, GFP_ATOMIC); > + ret = virtqueue_add_outbuf(cfv->vq_tx, &sg, 1, buf_info, GFP_ATOMIC); > > if (unlikely(WARN_ON(ret < 0))) { > kfree(buf_info); > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935203Ab3BTLMg (ORCPT ); Wed, 20 Feb 2013 06:12:36 -0500 Received: from cn.fujitsu.com ([222.73.24.84]:47997 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S935076Ab3BTLLZ (ORCPT ); Wed, 20 Feb 2013 06:11:25 -0500 X-IronPort-AV: E=Sophos;i="4.84,701,1355068800"; d="scan'208";a="6736124" Message-ID: <5124A1B8.7030102@cn.fujitsu.com> Date: Wed, 20 Feb 2013 18:13:12 +0800 From: Wanlong Gao Reply-To: gaowanlong@cn.fujitsu.com Organization: Fujitsu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Rusty Russell CC: Paolo Bonzini , Asias He , "Michael S. Tsirkin" , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH 13/16] caif_virtio: use simplified virtqueue accessors. References: <1361260594-601-1-git-send-email-rusty@rustcorp.com.au> <1361260594-601-14-git-send-email-rusty@rustcorp.com.au> In-Reply-To: <1361260594-601-14-git-send-email-rusty@rustcorp.com.au> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/02/20 18:13:32, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/02/20 18:13:34, Serialize complete at 2013/02/20 18:13:34 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/19/2013 03:56 PM, Rusty Russell wrote: > We never add buffers with input and output parts, so use the new accessors. > > Signed-off-by: Rusty Russell Reviewed-by: Wanlong Gao > --- > drivers/net/caif/caif_virtio.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/caif/caif_virtio.c b/drivers/net/caif/caif_virtio.c > index df832e7..9360055 100644 > --- a/drivers/net/caif/caif_virtio.c > +++ b/drivers/net/caif/caif_virtio.c > @@ -364,8 +364,7 @@ static int cfv_netdev_tx(struct sk_buff *skb, struct net_device *netdev) > /* Add buffer to avail ring. Flow control below should ensure > * that this always succeedes > */ > - ret = virtqueue_add_buf(cfv->vq_tx, &sg, 1, 0, > - buf_info, GFP_ATOMIC); > + ret = virtqueue_add_outbuf(cfv->vq_tx, &sg, 1, buf_info, GFP_ATOMIC); > > if (unlikely(WARN_ON(ret < 0))) { > kfree(buf_info); >