From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Date: Tue, 03 Jul 2018 14:58:11 +0000 Subject: Re: [PATCH 18/21] udlfb: allow reallocating the framebuffer Message-Id: <5125051.fdeVNsUfGe@amdc3058> List-Id: References: <20180603144225.463043082@twibright.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mikulas Patocka Cc: linux-fbdev@vger.kernel.org, Ladislav Michl , kbuild test robot , Bernie Thompson , dri-devel@lists.freedesktop.org, kbuild-all@01.org, Dave Airlie On Tuesday, June 12, 2018 12:32:34 PM Mikulas Patocka wrote: > > On Mon, 4 Jun 2018, kbuild test robot wrote: > > > Hi Mikulas, > > > > I love your patch! Perhaps something to improve: > > > > [auto build test WARNING on drm/drm-next] > > [also build test WARNING on v4.17-rc7 next-20180601] > > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > > > url: https://github.com/0day-ci/linux/commits/Mikulas-Patocka/USB-DisplayLink-patches/20180603-233013 > > What is it really complaining about? That URL shows 404 Not Found and this > email has no warnings at all. screen_base in struct fb_info is annotated with __iomem tag: ... char __iomem *screen_base; /* Virtual address */ ... and this tag should be preserved (or explicitly casted). > > base: git://people.freedesktop.org/~airlied/linux.git drm-next > > reproduce: > > # apt-get install sparse > > make ARCH=x86_64 allmodconfig > > make C=1 CF=-D__CHECK_ENDIAN__ You should be able to reproduce the issue with the above sequence. > > sparse warnings: (new ones prefixed by >>) [...] > > 1178 u32 old_len = info->fix.smem_len; > > > 1179 unsigned char *old_fb = info->screen_base; > > 1180 unsigned char *new_fb; [...] > > 1196 if (info->screen_base) { > > 1197 memcpy(new_fb, old_fb, old_len); > > > 1198 dlfb_deferred_vfree(dlfb, info->screen_base); > > 1199 } Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 18/21] udlfb: allow reallocating the framebuffer Date: Tue, 03 Jul 2018 16:58:11 +0200 Message-ID: <5125051.fdeVNsUfGe@amdc3058> References: <20180603144225.463043082@twibright.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 30E156E7B0 for ; Tue, 3 Jul 2018 14:58:16 +0000 (UTC) In-reply-to: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mikulas Patocka Cc: linux-fbdev@vger.kernel.org, Ladislav Michl , kbuild test robot , Bernie Thompson , dri-devel@lists.freedesktop.org, kbuild-all@01.org, Dave Airlie List-Id: dri-devel@lists.freedesktop.org T24gVHVlc2RheSwgSnVuZSAxMiwgMjAxOCAxMjozMjozNCBQTSBNaWt1bGFzIFBhdG9ja2Egd3Jv dGU6Cj4gCj4gT24gTW9uLCA0IEp1biAyMDE4LCBrYnVpbGQgdGVzdCByb2JvdCB3cm90ZToKPiAK PiA+IEhpIE1pa3VsYXMsCj4gPiAKPiA+IEkgbG92ZSB5b3VyIHBhdGNoISBQZXJoYXBzIHNvbWV0 aGluZyB0byBpbXByb3ZlOgo+ID4gCj4gPiBbYXV0byBidWlsZCB0ZXN0IFdBUk5JTkcgb24gZHJt L2RybS1uZXh0XQo+ID4gW2Fsc28gYnVpbGQgdGVzdCBXQVJOSU5HIG9uIHY0LjE3LXJjNyBuZXh0 LTIwMTgwNjAxXQo+ID4gW2lmIHlvdXIgcGF0Y2ggaXMgYXBwbGllZCB0byB0aGUgd3JvbmcgZ2l0 IHRyZWUsIHBsZWFzZSBkcm9wIHVzIGEgbm90ZSB0byBoZWxwIGltcHJvdmUgdGhlIHN5c3RlbV0K PiA+IAo+ID4gdXJsOiAgICBodHRwczovL2dpdGh1Yi5jb20vMGRheS1jaS9saW51eC9jb21taXRz L01pa3VsYXMtUGF0b2NrYS9VU0ItRGlzcGxheUxpbmstcGF0Y2hlcy8yMDE4MDYwMy0yMzMwMTMK PiAKPiBXaGF0IGlzIGl0IHJlYWxseSBjb21wbGFpbmluZyBhYm91dD8gVGhhdCBVUkwgc2hvd3Mg NDA0IE5vdCBGb3VuZCBhbmQgdGhpcyAKPiBlbWFpbCBoYXMgbm8gd2FybmluZ3MgYXQgYWxsLgoK c2NyZWVuX2Jhc2UgaW4gc3RydWN0IGZiX2luZm8gaXMgYW5ub3RhdGVkIHdpdGggX19pb21lbSB0 YWc6CgouLi4KCQljaGFyIF9faW9tZW0gKnNjcmVlbl9iYXNlOwkvKiBWaXJ0dWFsIGFkZHJlc3Mg Ki8KLi4uCgphbmQgdGhpcyB0YWcgc2hvdWxkIGJlIHByZXNlcnZlZCAob3IgZXhwbGljaXRseSBj YXN0ZWQpLgoKPiA+IGJhc2U6ICAgZ2l0Oi8vcGVvcGxlLmZyZWVkZXNrdG9wLm9yZy9+YWlybGll ZC9saW51eC5naXQgZHJtLW5leHQKPiA+IHJlcHJvZHVjZToKPiA+ICAgICAgICAgIyBhcHQtZ2V0 IGluc3RhbGwgc3BhcnNlCj4gPiAgICAgICAgIG1ha2UgQVJDSD14ODZfNjQgYWxsbW9kY29uZmln Cj4gPiAgICAgICAgIG1ha2UgQz0xIENGPS1EX19DSEVDS19FTkRJQU5fXwoKWW91IHNob3VsZCBi ZSBhYmxlIHRvIHJlcHJvZHVjZSB0aGUgaXNzdWUgd2l0aCB0aGUgYWJvdmUgc2VxdWVuY2UuCgo+ ID4gc3BhcnNlIHdhcm5pbmdzOiAobmV3IG9uZXMgcHJlZml4ZWQgYnkgPj4pCgpbLi4uXQoKPiA+ ICAgMTE3OAkJdTMyIG9sZF9sZW4gPSBpbmZvLT5maXguc21lbV9sZW47Cj4gPiA+IDExNzkJCXVu c2lnbmVkIGNoYXIgKm9sZF9mYiA9IGluZm8tPnNjcmVlbl9iYXNlOwo+ID4gICAxMTgwCQl1bnNp Z25lZCBjaGFyICpuZXdfZmI7CgpbLi4uXQoKPiA+ICAgMTE5NgkJCWlmIChpbmZvLT5zY3JlZW5f YmFzZSkgewo+ID4gICAxMTk3CQkJCW1lbWNweShuZXdfZmIsIG9sZF9mYiwgb2xkX2xlbik7Cj4g PiA+IDExOTgJCQkJZGxmYl9kZWZlcnJlZF92ZnJlZShkbGZiLCBpbmZvLT5zY3JlZW5fYmFzZSk7 Cj4gPiAgIDExOTkJCQl9CgpCZXN0IHJlZ2FyZHMsCi0tCkJhcnRsb21pZWogWm9sbmllcmtpZXdp Y3oKU2Ftc3VuZyBSJkQgSW5zdGl0dXRlIFBvbGFuZApTYW1zdW5nIEVsZWN0cm9uaWNzCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFp bGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK