From: Stephen Warren <swarren@wwwdotorg.org>
To: Anatolij Gustschin <agust@denx.de>
Cc: linux-input@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH v2] Input: matrix-keypad - support binary column select gpios
Date: Wed, 20 Feb 2013 14:09:03 -0700 [thread overview]
Message-ID: <51253B6F.10202@wwwdotorg.org> (raw)
In-Reply-To: <1361388475-23705-1-git-send-email-agust@denx.de>
On 02/20/2013 12:27 PM, Anatolij Gustschin wrote:
> On hardware with limited gpios one column select gpio can select
> two different rows when using some additional hardware logic:
> high value selects one row, low value selects another row. Add
> support for such matrix keyboards and document device tree
> bindings used to describe them.
>
> Since half of the columns is always not selected, interrupts won't be
> generated for press events on these columns. To generate interrupts
> for not selected columns we need to periodicaly switch to these columns
> in order to catch the potential press events. This is done by additional
> work function.
> diff --git a/Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt b/Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt
> +- col-gpios-binary: specify that high and low states of a column gpio
> + select two different rows (boards with limited gpios
> + could support this by additional hardware logic)
1 GPIO and 2 columns is essentially a special case with a 1->2 line decoder.
Do the binding definition and code work fine if you have e.g. 3 GPIOs,
and a 3->8 decoder in order to support 8 columns?
next prev parent reply other threads:[~2013-02-20 21:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-29 12:25 [PATCH] Input: matrix-keypad - support binary column select gpios Anatolij Gustschin
2013-01-30 1:16 ` Dmitry Torokhov
2013-01-30 8:44 ` Anatolij Gustschin
2013-02-20 19:27 ` [PATCH v2] " Anatolij Gustschin
2013-02-20 21:09 ` Stephen Warren [this message]
2013-02-21 7:41 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51253B6F.10202@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=agust@denx.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.