Re: [meta-oe][PATCH] macchanger: added 1.5.0 recipe

[Felipe Ferreri Tonello <eu@felipetonello.com>]

On 02/20/2013 01:02 PM, Paul Eggleton wrote:
> On Wednesday 20 February 2013 10:47:03 eu@felipetonello.com wrote:
>> From: "Felipe F. Tonello" <ftonello@cercacor.com>
>>
>> This is a useful utility to manipulate the mac address of a device.
>>
>> Signed-off-by: Felipe F. Tonello <ftonello@cercacor.com>
>> ---
>>   .../recipes-support/macchanger/macchanger_1.5.0.bb |   20
>> ++++++++++++++++++++ 1 file changed, 20 insertions(+)
>>   create mode 100644 meta-oe/recipes-support/macchanger/macchanger_1.5.0.bb
>>
>> diff --git a/meta-oe/recipes-support/macchanger/macchanger_1.5.0.bb
>> b/meta-oe/recipes-support/macchanger/macchanger_1.5.0.bb new file mode
>> 100644
>> index 0000000..21c8425
>> --- /dev/null
>> +++ b/meta-oe/recipes-support/macchanger/macchanger_1.5.0.bb
>> @@ -0,0 +1,20 @@
>> +SUMMARY = "macchanger"
>> +DESCRIPTION = "A GNU/Linux utility for viewing/manipulating the MAC address
>> of network interfaces."
>> +HOMEPAGE = "http://www.alobbs.com/macchanger"
>> +LICENSE  = "GPLv2"
>> +LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
>> +
>> +PR = "r2"
>> +
>> +SRC_URI  = "${GNU_MIRROR}/macchanger/${PN}-${PV}.tar.gz"
>> +
>> +SRC_URI[md5sum] = "79b7cdaeca3d8ebafa764c4b0dd03ab7"
>> +SRC_URI[sha256sum] =
>> "d44bfa27cb29c5a718627cb3ef3aa42eb5130426545eb2031120826cd73fa8fe" +
>> +FILES_${PN} = " \
>> +  ${bindir}/${PN} \
>> +  ${datadir}/${PN}/wireless.list \
>> +  ${datadir}/${PN}/OUI.list \
>> +"
>> +
>> +inherit autotools
>> \ No newline at end of file
>
> I think this should go in meta-networking rather than meta-oe. Also you should
> probably just do FILES_${PN} += "${datadir}/${PN}", remove PR, and set SUMMARY
> to something sensible e.g. "Tool to view/change network interface MAC
> addresses".

I will not add ${datadir}/${PN} to FILES_${PN} because this will add 
manuals and stuff that it's not necessary to the main package.

I will add to ${PN}-doc.

Felipe