All of lore.kernel.org
 help / color / mirror / Atom feed
From: ChenQi <Qi.Chen@windriver.com>
To: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
Cc: Zhenfeng.Zhao@windriver.com, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH V2 5/5] populate-volatile.sh: remove trailing whitespaces
Date: Thu, 21 Feb 2013 10:31:26 +0800	[thread overview]
Message-ID: <512586FE.8010100@windriver.com> (raw)
In-Reply-To: <CAC1BbcTWjtDiLeDa3970HAL5Za+9iA7sqfs6XsDqahEC4A49gg@mail.gmail.com>

On 02/20/2013 10:19 PM, Bernhard Reutner-Fischer wrote:
> On 20 February 2013 06:55,  <Qi.Chen@windriver.com> wrote:
>> From: Chen Qi <Qi.Chen@windriver.com>
>>
>> Remove trailing whitespaces.
>>
>> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
>> ---
>>   .../initscripts-1.0/populate-volatile.sh           |    6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/meta/recipes-core/initscripts/initscripts-1.0/populate-volatile.sh b/meta/recipes-core/initscripts/initscripts-1.0/populate-volatile.sh
>> index 24daeb4..d7937b4 100755
>> --- a/meta/recipes-core/initscripts/initscripts-1.0/populate-volatile.sh
>> +++ b/meta/recipes-core/initscripts/initscripts-1.0/populate-volatile.sh
>> @@ -48,9 +48,9 @@ create_file() {
>>   }
>>
>>   mk_dir() {
>> -       EXEC="
>> -       mkdir -p \"$1\";
>> -       chown ${TUSER}.${TGROUP} $1 || echo \"Failed to set owner -${TUSER}- for -$1-.\" >/dev/tty0 2>&1;
>> +       EXEC="
>> +       mkdir -p \"$1\";
>> +       chown ${TUSER}.${TGROUP} $1 || echo \"Failed to set owner -${TUSER}- for -$1-.\" >/dev/tty0 2>&1;
>>          chmod ${TMODE} $1 || echo \"Failed to set mode -${TMODE}- for -$1-.\" >/dev/tty0 2>&1 "
>>
>>          test "$VOLATILE_ENABLE_CACHE" = yes && echo "$EXEC" >> /etc/volatile.cache.build
> Don't you need ${ROOT_DIR}/etc/volatile.cache.build here (and
> everywhere else if there are other cases), too?
>
>
Actually no.

The cache is only enabled when ROOT_DIR is "/".
That is, the cache is disabled if populate-volatile.sh is run at rootfs 
time.

Best Regards,
Chen Qi



  reply	other threads:[~2013-02-21  2:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-20  5:55 [PATCH V2 0/5] Read-only rootfs followup patches Qi.Chen
2013-02-20  5:55 ` [PATCH V2 1/5] image.bbclass: add a hook funtion to support readonly rootfs Qi.Chen
2013-02-20  5:55 ` [PATCH V2 2/5] core-image.bbclass: support read-only rootfs Qi.Chen
2013-02-20  5:55 ` [PATCH V2 3/5] populate-volatile.sh: add ROOT_DIR variable to support running at rootfs time Qi.Chen
2013-02-20  5:55 ` [PATCH V2 4/5] populate-volatile.sh: improve the handling of link config items Qi.Chen
2013-02-20  7:10   ` Bernhard Reutner-Fischer
2013-02-20  7:16     ` ChenQi
2013-02-20  9:18       ` Bernhard Reutner-Fischer
2013-02-20  9:28         ` ChenQi
2013-02-20  5:55 ` [PATCH V2 5/5] populate-volatile.sh: remove trailing whitespaces Qi.Chen
2013-02-20 14:19   ` Bernhard Reutner-Fischer
2013-02-21  2:31     ` ChenQi [this message]
2013-02-21  7:20       ` Bernhard Reutner-Fischer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=512586FE.8010100@windriver.com \
    --to=qi.chen@windriver.com \
    --cc=Zhenfeng.Zhao@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=rep.dot.nop@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.