Re: [PATCH 3 of 5] tools/libxc: Implement of xc_readconsolering_buffer

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 21/02/13 10:01, Ian Campbell wrote:
> On Wed, 2013-02-20 at 18:05 +0000, Andrew Cooper wrote:
>> Functions identically to xc_readconsolering(), but uses a user-provided
>> xc_hypercall_buffer_t to save using a bounce buffer.
> Can we now trivially reimplement xc_readconsolering in terms of this
> function?
>
> Should just be a case of replacing all the code between bounce_pre and
> bounce_post with a call
> 	xc_readconsolering_buffer(xch, HYPERCALL_BUFFER_AS_ARG(buffer),
>                                   pnr_chars, clear, incremental, pindex);
> ?

Ok

>
> We should probably also deprecate the old one and at least have a vague
> idea that we might eventually switch all the callers over (you don't
> need to here though, unless you are super keen).
>
> Ian.
>

Depending on the quantity of callers, I may or may not due to time.

~Andrew