From mboxrd@z Thu Jan 1 00:00:00 1970 From: Glauber Costa Subject: Re: PROBLEM: Crash cgdeleting empty memory cgroups with memory.kmem.limit_in_bytes set Date: Thu, 21 Feb 2013 15:22:56 +0400 Message-ID: <51260390.8010203@parallels.com> References: <1361375371.7786.5.camel@michalke-online.eu> <20130220230019.GJ3570@htj.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130220230019.GJ3570-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Tejun Heo Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Michal Hocko , Johannes Weiner , Steffen Michalke List-Id: containers.vger.kernel.org On 02/21/2013 03:00 AM, Tejun Heo wrote: > (cc'ing cgroup / memcg people and quoting whole body) > > Looks like something is going wrong with memcg cache destruction. > Glauber, any ideas? Also, can we please not use names as generic as > kmem_cache_destroy_work_func for something specific to memcg? How > about something like memcg_destroy_cache_workfn? > > Thanks. Steffen, Is there any chance you could test that using SLAB instead of SLUB? I haven't manage to reproduce it yet, but I am working on some theories about why this is happening. If I could at least know if this is likely a cache problem vs a inner-memcg problem, that would help. The calltrace is not incredibly helpful, but it does indicate that the problem happens when freeing cache objects. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753514Ab3BULWz (ORCPT ); Thu, 21 Feb 2013 06:22:55 -0500 Received: from mx0.parallels.com ([199.115.104.20]:50796 "EHLO mx0.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751974Ab3BULWy (ORCPT ); Thu, 21 Feb 2013 06:22:54 -0500 Message-ID: <51260390.8010203@parallels.com> Date: Thu, 21 Feb 2013 15:22:56 +0400 From: Glauber Costa User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Tejun Heo CC: Steffen Michalke , , "Li Zefan" , , "Johannes Weiner" , Michal Hocko , Balbir Singh , KAMEZAWA Hiroyuki Subject: Re: PROBLEM: Crash cgdeleting empty memory cgroups with memory.kmem.limit_in_bytes set References: <1361375371.7786.5.camel@michalke-online.eu> <20130220230019.GJ3570@htj.dyndns.org> In-Reply-To: <20130220230019.GJ3570@htj.dyndns.org> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/21/2013 03:00 AM, Tejun Heo wrote: > (cc'ing cgroup / memcg people and quoting whole body) > > Looks like something is going wrong with memcg cache destruction. > Glauber, any ideas? Also, can we please not use names as generic as > kmem_cache_destroy_work_func for something specific to memcg? How > about something like memcg_destroy_cache_workfn? > > Thanks. Steffen, Is there any chance you could test that using SLAB instead of SLUB? I haven't manage to reproduce it yet, but I am working on some theories about why this is happening. If I could at least know if this is likely a cache problem vs a inner-memcg problem, that would help. The calltrace is not incredibly helpful, but it does indicate that the problem happens when freeing cache objects.