From: Chris Friesen <chris.friesen@genband.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: why is it not allowed to add a new socket protocol family as an external module?
Date: Thu, 21 Feb 2013 11:58:04 -0600 [thread overview]
Message-ID: <5126602C.5000003@genband.com> (raw)
In-Reply-To: <1361464988.17413.6.camel@edumazet-glaptop>
On 02/21/2013 10:43 AM, Eric Dumazet wrote:
> On Thu, 2013-02-21 at 09:47 -0600, Chris Friesen wrote:
>> The three lock_class_key structs (corresponding to
>> af_family_keys/af_family_slock_keys/af_callback_keys) can be
>> auto-allocated by the network core at dynamic registration time.
>
> Nope, this was the point I specifically raised but you missed it
>
> Take a look at kernel/lockdep.c, lines 2981-2988
>
> All the other stuff you mention seems pretty obvious.
Ah, sorry. I'm not familiar with the guts of lockdep, so I was not
aware that the keys needed to be static.
Given that the lockdep code considers module addresses to be okay, it
should work to make the keys static in the KLM implementing the new
protocol and pass the addresses in at registration time.
Chris
prev parent reply other threads:[~2013-02-21 17:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-20 16:56 why is it not allowed to add a new socket protocol family as an external module? Chris Friesen
2013-02-20 23:23 ` Stephen Hemminger
2013-02-21 0:44 ` Chris Friesen
2013-02-21 1:05 ` David Miller
2013-02-21 15:19 ` Chris Friesen
2013-02-21 1:39 ` Eric Dumazet
2013-02-21 15:47 ` Chris Friesen
2013-02-21 16:04 ` Stephen Hemminger
2013-02-21 16:19 ` Chris Friesen
2013-02-21 16:43 ` Eric Dumazet
2013-02-21 17:58 ` Chris Friesen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5126602C.5000003@genband.com \
--to=chris.friesen@genband.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.