Re: [Qemu-trivial] [Qemu-devel] [PATCH] xhci: fix bad print specifier

[Stefan Weil <sw@weilnetz.de>]

Am 21.02.2013 22:58, schrieb Hervé Poussineau:
> This fixes the following compilation error:
> hw/usb/hcd-xhci.c:1156:17: error: format ‘%llx’ expects argument of type
> ‘long long unsigned int’, but argument 4 has type ‘unsigned int’
>
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
> ---
>  hw/usb/hcd-xhci.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
> index 5796102..07afdee 100644
> --- a/hw/usb/hcd-xhci.c
> +++ b/hw/usb/hcd-xhci.c
> @@ -1152,8 +1152,8 @@ static XHCIStreamContext *xhci_find_stream(XHCIEPContext *epctx,
>  
>      if (sctx->sct == -1) {
>          xhci_dma_read_u32s(epctx->xhci, sctx->pctx, ctx, sizeof(ctx));
> -        fprintf(stderr, "%s: init sctx #%d @ %lx: %08x %08x\n", __func__,
> -                streamid, sctx->pctx, ctx[0], ctx[1]);
> +        fprintf(stderr, "%s: init sctx #%d @ " DMA_ADDR_FMT ": %08x %08x\n",
> +                __func__, streamid, sctx->pctx, ctx[0], ctx[1]);
>          sct = (ctx[0] >> 1) & 0x07;
>          if (epctx->lsa && sct != 1) {
>              *cc_error = CC_INVALID_STREAM_TYPE_ERROR;


Reviewed-by: Stefan Weil <sw@weilnetz.de>

Anthony, this is a build regression in git master, so we should not
wait for qemu-trivial to apply it.

Thanks,

Stefan