From: Laxman Dewangan <ldewangan@nvidia.com>
To: Ian Lartey <ian@slimlogic.co.uk>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>, "lrg@ti.com" <lrg@ti.com>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
Graeme Gregory <gg@slimlogic.co.uk>
Subject: Re: [PATCH 1/2] regulator: palmas fix SMPS no voltages
Date: Fri, 22 Feb 2013 16:11:32 +0530 [thread overview]
Message-ID: <51274B5C.4080601@nvidia.com> (raw)
In-Reply-To: <1361494325-4416-1-git-send-email-ian@slimlogic.co.uk>
On Friday 22 February 2013 06:22 AM, Ian Lartey wrote:
> From: Graeme Gregory <gg@slimlogic.co.uk>
>
> Number of voltages for SMPS regulators was off by one.
>
> Signed-off-by: Graeme Gregory <gg@slimlogic.co.uk>
> Signed-off-by: Ian Lartey <ian@slimlogic.co.uk>
> ---
> drivers/regulator/palmas-regulator.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c
> index cde13bb..39cf146 100644
> --- a/drivers/regulator/palmas-regulator.c
> +++ b/drivers/regulator/palmas-regulator.c
> @@ -4,6 +4,7 @@
> * Copyright 2011-2012 Texas Instruments Inc.
> *
> * Author: Graeme Gregory <gg@slimlogic.co.uk>
> + * Author: Ian Lartey <ian@slimlogic.co.uk>
> *
> * This program is free software; you can redistribute it and/or modify it
> * under the terms of the GNU General Public License as published by the
> @@ -156,7 +157,7 @@ static const struct regs_info palmas_regs_info[] = {
> *
> * So they are basically (maxV-minV)/stepV
> */
> -#define PALMAS_SMPS_NUM_VOLTAGES 116
> +#define PALMAS_SMPS_NUM_VOLTAGES 117
Yes, if we keep one for 0.5V and one for 1.65 the it becomes 117
including off.
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
prev parent reply other threads:[~2013-02-22 10:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 0:52 [PATCH 1/2] regulator: palmas fix SMPS no voltages Ian Lartey
2013-02-22 0:52 ` [PATCH 2/2] mfd: palmas add variant and OTP detection Ian Lartey
2013-02-22 10:30 ` Laxman Dewangan
2013-02-22 15:52 ` Ian Lartey
2013-02-22 10:41 ` Laxman Dewangan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51274B5C.4080601@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=gg@slimlogic.co.uk \
--cc=ian@slimlogic.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.