From: Stefan Weil <sw@weilnetz.de>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
qemu-devel <qemu-devel@nongnu.org>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH][RESENT] configure: Create link to icon bitmap for out-of-tree builds
Date: Fri, 22 Feb 2013 21:28:37 +0100 [thread overview]
Message-ID: <5127D4F5.5000002@weilnetz.de> (raw)
In-Reply-To: <5127CF6D.2060104@siemens.com>
Am 22.02.2013 21:05, schrieb Jan Kiszka:
> This allows to pick up the icon when starting QEMU directly from an
> out-of-tree build directory.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> configure | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/configure b/configure
> index 0eb25dd..265d8f7 100755
> --- a/configure
> +++ b/configure
> @@ -4342,6 +4342,7 @@ FILES="$FILES tests/tcg/lm32/Makefile po/Makefile"
> FILES="$FILES pc-bios/optionrom/Makefile pc-bios/keymaps"
> FILES="$FILES pc-bios/spapr-rtas/Makefile"
> FILES="$FILES roms/seabios/Makefile roms/vgabios/Makefile"
> +FILES="$FILES pc-bios/qemu-icon.bmp"
> for bios_file in \
> $source_path/pc-bios/*.bin \
> $source_path/pc-bios/*.aml \
I have a similar patch in my tree since two years (don't know
why I never sent it). The only difference is the order (I prefer
alphabetic order for such lines). If you decide to reorder,
you may add my Reviewed-by as well.
Reviewed-by: Stefan Weil <sw@weilnetz.de>
next prev parent reply other threads:[~2013-02-22 20:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 20:05 [Qemu-trivial] [PATCH][RESENT] configure: Create link to icon bitmap for out-of-tree builds Jan Kiszka
2013-02-22 20:28 ` Stefan Weil [this message]
2013-03-08 9:15 ` Stefan Hajnoczi
2013-03-08 9:15 ` [Qemu-devel] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5127D4F5.5000002@weilnetz.de \
--to=sw@weilnetz.de \
--cc=afaerber@suse.de \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.