From: Jeff Liu <jeff.liu@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2: fix ocfs2_init_security_and_acl() to initialize acl correctly
Date: Sat, 23 Feb 2013 10:12:10 +0800 [thread overview]
Message-ID: <5128257A.8010103@oracle.com> (raw)
In-Reply-To: <20130222132140.0e093dfd.akpm@linux-foundation.org>
Hi Andrew,
On 02/23/2013 05:21 AM, Andrew Morton wrote:
> On Fri, 22 Feb 2013 19:15:46 +0800
> Jeff Liu <jeff.liu@oracle.com> wrote:
>
>> We need to re-initialize the security if it isn't preserved for ocfs2_reflink().
>> however, the code logic is broken at ocfs2_init_security_and_acl() although
>> ocfs2_init_security_get() succeed, as a result, ocfs2_acl_init() does not involked.
>
> When writing a changelog, please describe the end-user-visible effects
> of the bug, so that others can more easily decide which kernel
> version(s) should be fixed, and so that downstream kernel maintainers
> can more easily work out whether this patch will fix a problem which
> they or their customers are observing.
Thanks for your teaching, I'll take care of it next time.
Regards,
-Jeff
next prev parent reply other threads:[~2013-02-23 2:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 11:15 [Ocfs2-devel] [PATCH] ocfs2: fix ocfs2_init_security_and_acl() to initialize acl correctly Jeff Liu
2013-02-22 21:21 ` Andrew Morton
2013-02-23 2:12 ` Jeff Liu [this message]
2013-02-23 2:31 ` Andrew Morton
2013-02-23 4:22 ` Jeff Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5128257A.8010103@oracle.com \
--to=jeff.liu@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.