From: Stephen Warren <swarren@wwwdotorg.org>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Dong Aisheng <dong.aisheng@linaro.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Thierry Reding <thierry.reding@avionic-design.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v5 1/3] mfd: syscon: Removed support for unloading
Date: Sat, 23 Feb 2013 16:51:19 -0700 [thread overview]
Message-ID: <512955F7.1020309@wwwdotorg.org> (raw)
In-Reply-To: <1361597308.137178281@f2.mail.ru>
On 02/22/2013 10:28 PM, Alexander Shiyan wrote:
>> On 02/22/2013 10:15 PM, Alexander Shiyan wrote:
>>> The driver can be used in various subsystems and therefore should not
>>> be unloaded when it is defined in the kernel configuration, so remove
>>> support for unloading it.
>>
>> Why not fix the clients to module_get() at the appropriate times; then
>> you could still allow unloading, couldn't you?
>
> I has explain this before.
If multiple people have asked this, perhaps it'd be a good idea to
include the answer in the commit description.
> Driver defined as "bool" and loaded via postcore_initcall.
Being defined as a "bool" sounds like a reasonable reason that no
remove() is required.
Being loaded via postcore_initcall() (a) should have absolutely no
influence over whether a remove() is required (an actual module could
just as well include a postcore_initcall function, which would get
executed at module load time), and (b) is wrong; initcall ordering
shouldn't be used to influence driver probe ordering.
next prev parent reply other threads:[~2013-02-23 23:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-23 5:15 [PATCH v5 1/3] mfd: syscon: Removed support for unloading Alexander Shiyan
2013-02-23 5:15 ` [PATCH v5 2/3] mfd: syscon: Removed unneeded field "dev" from private driver structure Alexander Shiyan
2013-02-23 5:15 ` [PATCH v5 3/3] mfd: syscon: Add non-DT support Alexander Shiyan
2013-02-23 5:21 ` [PATCH v5 1/3] mfd: syscon: Removed support for unloading Stephen Warren
2013-02-23 5:28 ` Re[2]: " Alexander Shiyan
2013-02-23 23:51 ` Stephen Warren [this message]
2013-02-24 7:55 ` Dmitry Torokhov
2013-02-25 6:53 ` Re[2]: " Alexander Shiyan
2013-02-25 7:07 ` Dmitry Torokhov
2013-02-23 22:17 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512955F7.1020309@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=arnd@arndb.de \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dong.aisheng@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=shc_work@mail.ru \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.