All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wido den Hollander <wido@42on.com>
To: Sage Weil <sage@inktank.com>
Cc: "Sébastien Han" <han.sebastien@gmail.com>,
	"Gregory Farnum" <greg@inktank.com>,
	"Sylvain Munaut" <s.munaut@whatever-company.com>,
	"Dave Spano" <dspano@optogenics.com>,
	ceph-devel <ceph-devel@vger.kernel.org>,
	"Samuel Just" <sam.just@inktank.com>
Subject: Re: OSD memory leaks?
Date: Mon, 25 Feb 2013 08:51:20 +0100	[thread overview]
Message-ID: <512B17F8.2090604@42on.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1302241619380.26649@cobra.newdream.net>

On 02/25/2013 01:21 AM, Sage Weil wrote:
> On Mon, 25 Feb 2013, S?bastien Han wrote:
>> Hi Sage,
>>
>> Sorry it's a production system, so I can't test it.
>> So at the end, you can't get anything out of the core dump?
>
> I saw a bunch of dup object anmes, which is what led us to the pg log
> theory.  I can look a bit more carefully to confirm, but in the end it
> would be nice to see users scrubbing without leaking.
>
> This may be a bit moot because we want to allow trimming for other
> reasons, so those patches are being tested and working their way into
> master.  We'll backport when things are solid.
>
> In the meantime, if someone has been able to reproduce this in a test
> environment, testing is obviously welcome :)
>

I'll see what I can do later this week. I know of a cluster which has 
the same issues which is in semi-production as far as I know.

Wido

> sage
>
>
>
>
>   >
>> --
>> Regards,
>> S?bastien Han.
>>
>>
>> On Sat, Feb 23, 2013 at 1:44 AM, Sage Weil <sage@inktank.com> wrote:
>>> On Fri, 22 Feb 2013, S?bastien Han wrote:
>>>> Hi all,
>>>>
>>>> I finally got a core dump.
>>>>
>>>> I did it with a kill -SEGV on the OSD process.
>>>>
>>>> https://www.dropbox.com/s/ahv6hm0ipnak5rf/core-ceph-osd-11-0-0-20100-1361539008
>>>>
>>>> Hope we will get something out of it :-).
>>>
>>> AHA!  We have a theory.  The pg log isnt trimmed during scrub (because teh
>>> old scrub code required that), but the new (deep) scrub can take a very
>>> long time, which means the pg log will eat ram in the meantime..
>>> especially under high iops.
>>>
>>> Can you try wip-osd-log-trim (which is bobtail + a simple patch) and see
>>> if that seems to work?  Note that that patch shouldn't be run in a mixed
>>> argonaut+bobtail cluster, since it isn't properly checking if the scrub is
>>> class or chunky/deep.
>>>
>>> Thanks!
>>> sage
>>>
>>>
>>>   > --
>>>> Regards,
>>>> S?bastien Han.
>>>>
>>>>
>>>> On Fri, Jan 11, 2013 at 7:13 PM, Gregory Farnum <greg@inktank.com> wrote:
>>>>> On Fri, Jan 11, 2013 at 6:57 AM, S?bastien Han <han.sebastien@gmail.com> wrote:
>>>>>>> Is osd.1 using the heap profiler as well? Keep in mind that active use
>>>>>>> of the memory profiler will itself cause memory usage to increase ?
>>>>>>> this sounds a bit like that to me since it's staying stable at a large
>>>>>>> but finite portion of total memory.
>>>>>>
>>>>>> Well, the memory consumption was already high before the profiler was
>>>>>> started. So yes with the memory profiler enable an OSD might consume
>>>>>> more memory but this doesn't cause the memory leaks.
>>>>>
>>>>> My concern is that maybe you saw a leak but when you restarted with
>>>>> the memory profiling you lost whatever conditions caused it.
>>>>>
>>>>>> Any ideas? Nothing to say about my scrumbing theory?
>>>>> I like it, but Sam indicates that without some heap dumps which
>>>>> capture the actual leak then scrub is too large to effectively code
>>>>> review for leaks. :(
>>>>> -Greg
>>>> --
>>>> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
>>>> the body of a message to majordomo@vger.kernel.org
>>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>>>
>>>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>>
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>


-- 
Wido den Hollander
42on B.V.

Phone: +31 (0)20 700 9902
Skype: contact42on

  reply	other threads:[~2013-02-25  7:51 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4172429.450.1357580400977.JavaMail.dspano@it1>
     [not found] ` <10953797.470.1357585419142.JavaMail.dspano@it1>
2013-01-07 19:09   ` OSD memory leaks? Samuel Just
2013-01-09 15:20     ` Sébastien Han
2013-01-09 16:10       ` Dave Spano
2013-01-09 16:35         ` Sébastien Han
2013-01-09 18:09           ` Sylvain Munaut
2013-01-09 19:11             ` Sébastien Han
2013-01-10 21:44             ` Gregory Farnum
2013-01-11 14:57               ` Sébastien Han
2013-01-11 18:13                 ` Gregory Farnum
2013-02-22 15:24                   ` Sébastien Han
2013-02-23  0:44                     ` Sage Weil
2013-02-24 23:10                       ` Sébastien Han
2013-02-25  0:21                         ` Sage Weil
2013-02-25  7:51                           ` Wido den Hollander [this message]
2013-02-25 17:18                             ` Sébastien Han
2013-03-01 15:51                       ` Wido den Hollander
2013-03-01 18:07                         ` Samuel Just
2013-03-01 19:10                         ` Sage Weil
2013-03-04 17:11                           ` Sébastien Han
     [not found]                             ` <13183200.155.1363027427897.JavaMail.dspano@it1>
2013-03-11 22:23                               ` Sébastien Han
2013-03-12 11:45                             ` Vladislav Gorbunov
2013-03-12 12:12                               ` Sébastien Han
2013-03-12 13:00                                 ` Vladislav Gorbunov
2013-03-12 13:43                                   ` Sébastien Han
2013-01-09 21:42           ` Dave Spano
2013-01-09 22:12             ` Sébastien Han
2013-01-09 23:03               ` Dave Spano
2013-01-10 21:43         ` Gregory Farnum
     [not found] <7332688.5.1363110084349.JavaMail.dspano@it1>
2013-03-12 18:09 ` Dave Spano
2013-03-12 20:10   ` Sébastien Han
2013-03-12 20:20     ` Greg Farnum
2013-03-12 21:15       ` Dave Spano
2013-03-12 21:37         ` Greg Farnum
2013-03-13 13:12           ` Dave Spano
2013-03-13 19:59             ` Sébastien Han
2013-03-13 22:38               ` Dave Spano
2013-03-13 22:52                 ` Greg Farnum
2013-03-14  0:05                   ` Dave Spano
2013-03-14  0:15                     ` Josh Durgin
2013-03-14 21:28               ` Dave Spano
2013-03-12 21:01     ` Bryan K. Wright
     [not found] <CAOLwVUmJb0y39dg3zTv=c4iPSkjLBhG3L7L4=L7Ms96iP-SiWw@mail.gmail.com>
2012-12-17  8:28 ` Fwd: " Sébastien Han
2012-12-17 18:12   ` Samuel Just
     [not found]     ` <CAOLwVUn5VbH1P=0wu-Oxb1bSKpaQfC6uQ5012wvPc7bvz606JA@mail.gmail.com>
2012-12-17 22:41       ` Sébastien Han
2012-12-17 22:55         ` Samuel Just
2012-12-18 17:21           ` Sébastien Han
2012-12-19 16:37             ` Sébastien Han
2012-12-19 21:43               ` Samuel Just
2013-01-04 15:20                 ` Sébastien Han

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=512B17F8.2090604@42on.com \
    --to=wido@42on.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=dspano@optogenics.com \
    --cc=greg@inktank.com \
    --cc=han.sebastien@gmail.com \
    --cc=s.munaut@whatever-company.com \
    --cc=sage@inktank.com \
    --cc=sam.just@inktank.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.