From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <512B3B93.2050504@suse.cz> Date: Mon, 25 Feb 2013 11:23:15 +0100 From: Jiri Slaby MIME-Version: 1.0 To: Bjorn Helgaas CC: Konstantin Khlebnikov , "Wysocki, Rafael J" , linux-pci@vger.kernel.org, LKML Subject: Re: WARNING: at drivers/pci/pci.c:1397 pci_disable_device References: <5123C5A5.4000106@suse.cz> <512A85F4.1040906@suse.cz> In-Reply-To: <512A85F4.1040906@suse.cz> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: On 02/24/2013 10:28 PM, Jiri Slaby wrote: > On 02/19/2013 07:53 PM, Bjorn Helgaas wrote: >> On Tue, Feb 19, 2013 at 11:34 AM, Jiri Slaby wrote: >>> Hi, >>> >>> so I hit that one: >>> + dev_WARN_ONCE(&dev->dev, atomic_read(&dev->enable_cnt) <= 0, >>> + "disabling already-disabled device"); >>> >>> during suspend (to ram): >>> WARNING: at drivers/pci/pci.c:1397 pci_disable_device+0x90/0xa0() >>> Hardware name: To Be Filled By O.E.M. >>> Device e1000e >>> disabling already-disabled device >>> Modules linked in: dvb_usb_dib0700 dib0090 dib7000p dib7000m dib0070 >>> dib8000 dib3000mc dibx000_common microcode >>> Pid: 31027, comm: kworker/u:35 Not tainted 3.8.0-rc7-next-20130218_64+ #1768 >>> Call Trace: >>> [] ? do_pci_disable_device+0x30/0x60 >>> [] warn_slowpath_common+0x7f/0xc0 >>> [] warn_slowpath_fmt+0x46/0x50 >>> [] pci_disable_device+0x90/0xa0 >>> [] __e1000_shutdown+0x262/0x8b0 >>> [] e1000_suspend+0x23/0x50 >>> [] ? wait_for_completion+0x31/0x100 >>> [] pci_pm_suspend+0x77/0x140 >>> [] ? __pm_runtime_barrier+0x1a/0x130 >>> [] ? pci_pm_poweroff+0xf0/0xf0 >>> [] dpm_run_callback+0x58/0x90 >>> [] __device_suspend+0xeb/0x280 >>> [] async_suspend+0x1f/0xa0 >>> [] async_run_entry_fn+0x3b/0x140 >>> [] process_one_work+0x174/0x410 >>> [] worker_thread+0x116/0x400 >>> [] ? busy_worker_rebind_fn+0xc0/0xc0 >>> [] kthread+0xc0/0xd0 >>> [] ? kthread_create_on_node+0x130/0x130 >>> [] ret_from_fork+0x7c/0xb0 >>> [] ? kthread_create_on_node+0x130/0x130 >>> ---[ end trace 6c5060f8b8fb9175 ]--- >>> e1000e 0000:00:19.0: System wakeup enabled by ACPI >> >> I think Konstantin posted an e1000e patch that would fix this, but >> it's going via the e1000e folks. Hopefully both my tree and the >> e1000e patch will be merged soon. > > I'm using -next anyway, so is there any chance it is fixed there some > time soon? Nevermind, I've just applied "e1000e: fix pci-device enable-counter balance" which should fix that, I suppose. > thanks, -- js suse labs