From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Langsdorf Subject: Re: [PATCH v2] cpufreq: highbank: do not initialize array with a loop Date: Mon, 25 Feb 2013 07:53:47 -0600 Message-ID: <512B6CEB.1030203@calxeda.com> References: <1361725277-5125-1-git-send-email-emilio@elopez.com.ar> <1361790465-21760-1-git-send-email-emilio@elopez.com.ar> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1361790465-21760-1-git-send-email-emilio@elopez.com.ar> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: =?UTF-8?B?RW1pbGlvIEzDs3Bleg==?= Cc: "linux-pm@vger.kernel.org" , "viresh.kumar@linaro.org" , "linux-kernel@vger.kernel.org" , "cpufreq@vger.kernel.org" , "rjw@sisk.pl" , "shawn.guo@linaro.org" , "linux-arm-kernel@lists.infradead.org" T24gMDIvMjUvMjAxMyAwNTowNyBBTSwgRW1pbGlvIEzDs3BleiB3cm90ZToKPiBBcyB1bmluaXRp YWxpemVkIGFycmF5IG1lbWJlcnMgd2lsbCBiZSBpbml0aWFsaXplZCB0byB6ZXJvLCB3ZSBjYW4K PiBhdm9pZCB1c2luZyBhIGZvciBsb29wIGJ5IHNldHRpbmcgYSB2YWx1ZSB0byBpdC4KPiAKPiBT aWduZWQtb2ZmLWJ5OiBFbWlsaW8gTMOzcGV6IDxlbWlsaW9AZWxvcGV6LmNvbS5hcj4KPiAtLS0K PiAKPiBOb3RlIHRoYXQgSSBkb24ndCBvd24gYW55IGRldmljZSB1c2luZyB0aGlzIGRyaXZlciwg aXQgaGFzIG9ubHkgYmVlbiBjb21waWxlCj4gdGVzdGVkLCBidXQgaXQgc2hvdWxkbid0IGNhdXNl IGFueSBpc3N1ZXMuCj4gCj4gQ2hhbmdlcyB2MSAtPiB2MjoKPiAgICogTW92ZSBmcmVxIC8gMTAw MDAwMCB0byB0aGUgYXJyYXkgZGVmaW5pdGlvbiBhcyBzdWdnZXN0ZWQgYnkgVmlyZXNoIEt1bWFy Cj4gCj4gIGRyaXZlcnMvY3B1ZnJlcS9oaWdoYmFuay1jcHVmcmVxLmMgfCA4ICstLS0tLS0tCj4g IDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgNyBkZWxldGlvbnMoLSkKPiAKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9jcHVmcmVxL2hpZ2hiYW5rLWNwdWZyZXEuYyBiL2RyaXZlcnMvY3B1 ZnJlcS9oaWdoYmFuay1jcHVmcmVxLmMKPiBpbmRleCA2NmUzYTcxLi5iNjFiNWEzIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvY3B1ZnJlcS9oaWdoYmFuay1jcHVmcmVxLmMKPiArKysgYi9kcml2ZXJz L2NwdWZyZXEvaGlnaGJhbmstY3B1ZnJlcS5jCj4gQEAgLTI4LDEzICsyOCw3IEBACj4gIAo+ICBz dGF0aWMgaW50IGhiX3ZvbHRhZ2VfY2hhbmdlKHVuc2lnbmVkIGludCBmcmVxKQo+ICB7Cj4gLQlp bnQgaTsKPiAtCXUzMiBtc2dbSEJfQ1BVRlJFUV9JUENfTEVOXTsKPiAtCj4gLQltc2dbMF0gPSBI Ql9DUFVGUkVRX0NIQU5HRV9OT1RFOwo+IC0JbXNnWzFdID0gZnJlcSAvIDEwMDAwMDA7Cj4gLQlm b3IgKGkgPSAyOyBpIDwgSEJfQ1BVRlJFUV9JUENfTEVOOyBpKyspCj4gLQkJbXNnW2ldID0gMDsK PiArCXUzMiBtc2dbSEJfQ1BVRlJFUV9JUENfTEVOXSA9IHtIQl9DUFVGUkVRX0NIQU5HRV9OT1RF LCBmcmVxIC8gMTAwMDAwMH07Cj4gIAo+ICAJcmV0dXJuIHBsMzIwX2lwY190cmFuc21pdChtc2cp Owo+ICB9Cj4gClRoYW5rcyBmb3IgdGhlIGltcHJvdmVtZW50LgoKQWNrZWQtQnk6IE1hcmsgTGFu Z3Nkb3JmIDxtYXJrLmxhbmdzZG9yZkBjYWx4ZWRhLmNvbT4KCi0tTWFyayBMYW5nc2RvcmYKQ2Fs eGVkYSwgSW5jLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.langsdorf@calxeda.com (Mark Langsdorf) Date: Mon, 25 Feb 2013 07:53:47 -0600 Subject: [PATCH v2] cpufreq: highbank: do not initialize array with a loop In-Reply-To: <1361790465-21760-1-git-send-email-emilio@elopez.com.ar> References: <1361725277-5125-1-git-send-email-emilio@elopez.com.ar> <1361790465-21760-1-git-send-email-emilio@elopez.com.ar> Message-ID: <512B6CEB.1030203@calxeda.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/25/2013 05:07 AM, Emilio L?pez wrote: > As uninitialized array members will be initialized to zero, we can > avoid using a for loop by setting a value to it. > > Signed-off-by: Emilio L?pez > --- > > Note that I don't own any device using this driver, it has only been compile > tested, but it shouldn't cause any issues. > > Changes v1 -> v2: > * Move freq / 1000000 to the array definition as suggested by Viresh Kumar > > drivers/cpufreq/highbank-cpufreq.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/cpufreq/highbank-cpufreq.c b/drivers/cpufreq/highbank-cpufreq.c > index 66e3a71..b61b5a3 100644 > --- a/drivers/cpufreq/highbank-cpufreq.c > +++ b/drivers/cpufreq/highbank-cpufreq.c > @@ -28,13 +28,7 @@ > > static int hb_voltage_change(unsigned int freq) > { > - int i; > - u32 msg[HB_CPUFREQ_IPC_LEN]; > - > - msg[0] = HB_CPUFREQ_CHANGE_NOTE; > - msg[1] = freq / 1000000; > - for (i = 2; i < HB_CPUFREQ_IPC_LEN; i++) > - msg[i] = 0; > + u32 msg[HB_CPUFREQ_IPC_LEN] = {HB_CPUFREQ_CHANGE_NOTE, freq / 1000000}; > > return pl320_ipc_transmit(msg); > } > Thanks for the improvement. Acked-By: Mark Langsdorf --Mark Langsdorf Calxeda, Inc. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758971Ab3BYNyw (ORCPT ); Mon, 25 Feb 2013 08:54:52 -0500 Received: from smtp153.dfw.emailsrvr.com ([67.192.241.153]:33845 "EHLO smtp153.dfw.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758612Ab3BYNyt (ORCPT ); Mon, 25 Feb 2013 08:54:49 -0500 Message-ID: <512B6CEB.1030203@calxeda.com> Date: Mon, 25 Feb 2013 07:53:47 -0600 From: Mark Langsdorf User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-Version: 1.0 To: =?UTF-8?B?RW1pbGlvIEzDs3Bleg==?= CC: "viresh.kumar@linaro.org" , "rjw@sisk.pl" , "shawn.guo@linaro.org" , "linux-arm-kernel@lists.infradead.org" , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] cpufreq: highbank: do not initialize array with a loop References: <1361725277-5125-1-git-send-email-emilio@elopez.com.ar> <1361790465-21760-1-git-send-email-emilio@elopez.com.ar> In-Reply-To: <1361790465-21760-1-git-send-email-emilio@elopez.com.ar> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/25/2013 05:07 AM, Emilio López wrote: > As uninitialized array members will be initialized to zero, we can > avoid using a for loop by setting a value to it. > > Signed-off-by: Emilio López > --- > > Note that I don't own any device using this driver, it has only been compile > tested, but it shouldn't cause any issues. > > Changes v1 -> v2: > * Move freq / 1000000 to the array definition as suggested by Viresh Kumar > > drivers/cpufreq/highbank-cpufreq.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/cpufreq/highbank-cpufreq.c b/drivers/cpufreq/highbank-cpufreq.c > index 66e3a71..b61b5a3 100644 > --- a/drivers/cpufreq/highbank-cpufreq.c > +++ b/drivers/cpufreq/highbank-cpufreq.c > @@ -28,13 +28,7 @@ > > static int hb_voltage_change(unsigned int freq) > { > - int i; > - u32 msg[HB_CPUFREQ_IPC_LEN]; > - > - msg[0] = HB_CPUFREQ_CHANGE_NOTE; > - msg[1] = freq / 1000000; > - for (i = 2; i < HB_CPUFREQ_IPC_LEN; i++) > - msg[i] = 0; > + u32 msg[HB_CPUFREQ_IPC_LEN] = {HB_CPUFREQ_CHANGE_NOTE, freq / 1000000}; > > return pl320_ipc_transmit(msg); > } > Thanks for the improvement. Acked-By: Mark Langsdorf --Mark Langsdorf Calxeda, Inc.