From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757867Ab3BYRFd (ORCPT ); Mon, 25 Feb 2013 12:05:33 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:36283 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757010Ab3BYRFc (ORCPT ); Mon, 25 Feb 2013 12:05:32 -0500 Message-ID: <512B99D1.7060509@oracle.com> Date: Mon, 25 Feb 2013 12:05:21 -0500 From: konrad wilk Organization: Oracle Corporation User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130215 Thunderbird/17.0.3 MIME-Version: 1.0 To: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= CC: "linux-kernel@vger.kernel.org" , "xen-devel@lists.xen.org" Subject: Re: [Xen-devel] [PATCH] xen-blkfront: switch from llist to list References: <1360951381-26313-1-git-send-email-roger.pau@citrix.com> <20130215185644.GB29539@phenom.dumpdata.com> <511E88B4.7060205@citrix.com> <20130225164929.GB10672@phenom.dumpdata.com> <512B98C9.2020008@citrix.com> In-Reply-To: <512B98C9.2020008@citrix.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-Source-IP: acsinet21.oracle.com [141.146.126.237] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/25/2013 12:00 PM, Roger Pau Monné wrote: > On 25/02/13 17:49, Konrad Rzeszutek Wilk wrote: >> On Fri, Feb 15, 2013 at 08:12:52PM +0100, Roger Pau Monné wrote: >>> On 15/02/13 19:56, Konrad Rzeszutek Wilk wrote: >>>>> Should be backported to 3.8 stable. >>>> Lets do one thing at a time. >>>> >>>> The patch I have in the tree (and that I've asked Jens to pull for 3.9 - so >>>> he might have already in his tree) is the old hybrid where we still use llist >>>> but change the loop from 'for' to 'while'. >>>> >>>> This is the stable/for-jens-3.8 tree in git://git.kernel.org/pub/scm/linux/kernel/git/konrad/xen.git >>>> >>>> Could you rebase your patch on top of that tree and just simplify the loop? >>>> >>>> Sorry about the mess about this - but I had already pulled the trigger >>>> so to say - hoping that Jens would pull the tree and do a git pull to Linus. >>>> >>>> And you are absolutly sure that we don't need any extra locking when switching >>>> over to list_head? Say if blkif_completion is called while we are >>>> processing in blkif_queue_request and doing ? >>> Will recheck it, but blkif_completition is called with the io_lock hold, >>> as does blkif_queue_request (I've added extra assert_spin_locked before >>> every list modification). >> Can you rebase this patch on top of 'stable/for-jens-3.9' when you get a chance >> please? > Yes, I was going to resubmit it as part of my indirect descriptors > series (which I'm hoping to send before the end of the week), but if you > are in a rush I can send it earlier, I already have it rebased on top of > for-jens-3.9. No rush. Just want to make sure it did not get lost. Thanks!