From: "Jun'ichi Nomura" <j-nomura@ce.jp.nec.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: device-mapper development <dm-devel@redhat.com>,
linux-scsi <linux-scsi@vger.kernel.org>,
Alasdair G Kergon <agk@redhat.com>, Jens Axboe <axboe@kernel.dk>,
Mike Snitzer <snitzer@redhat.com>, Tejun Heo <tj@kernel.org>,
James Bottomley <JBottomley@parallels.com>
Subject: Re: [PATCH 2/2] dm: Avoid use-after-free of a mapped device
Date: Tue, 26 Feb 2013 09:30:57 +0900 [thread overview]
Message-ID: <512C0241.7050500@ce.jp.nec.com> (raw)
In-Reply-To: <512B7EC0.8090400@acm.org>
On 02/26/13 00:09, Bart Van Assche wrote:
> Without your patch my test failed after two or three iterations. With your patch my test is still running after 53 iterations. So if you want you can add Tested-by: Bart Van Assche <bvanassche@acm.org>.
Great. Thanks for testing.
I'll submit a patch with your Reported-by and Tested-by.
> Your e-mail and the above patch are also interesting because these explain why reverting to the v3.7 of drivers/md made my test succeed.
>
> Note: even if this patch gets accepted I think it's still useful to modify blk_run_queue() such that it converts recursion into iteration.
Yes. That's a separate discussion.
Though I'm not sure if it's ok in general to implicitly convert
sync run-queue to async one.
--
Jun'ichi Nomura, NEC Corporation
prev parent reply other threads:[~2013-02-26 0:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 10:45 [PATCH 0/2] dm: Avoid use-after-free of a mapped device Bart Van Assche
2013-02-22 10:46 ` [PATCH 1/2] block: Avoid invoking blk_run_queue() recursively Bart Van Assche
2013-02-22 18:14 ` Tejun Heo
2013-02-22 18:57 ` Bart Van Assche
2013-02-22 19:01 ` Jens Axboe
2013-02-23 12:34 ` Bart Van Assche
2013-02-22 10:47 ` [PATCH 2/2] dm: Avoid use-after-free of a mapped device Bart Van Assche
2013-02-22 11:08 ` Mike Snitzer
2013-02-22 11:22 ` Bart Van Assche
2013-02-22 11:28 ` Mike Snitzer
2013-02-25 9:49 ` Jun'ichi Nomura
2013-02-25 15:09 ` Bart Van Assche
2013-02-26 0:30 ` Jun'ichi Nomura [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512C0241.7050500@ce.jp.nec.com \
--to=j-nomura@ce.jp.nec.com \
--cc=JBottomley@parallels.com \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=dm-devel@redhat.com \
--cc=linux-scsi@vger.kernel.org \
--cc=snitzer@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.