Re: [PATCH] ideapad-laptop: Depend on BACKLIGHT_CLASS_DEVICE instead of selecting it

[Ike Panhc <ike.pan@canonical.com>]

On 02/26/2013 06:01 AM, Matthew Garrett wrote:
> Selecting BACKLIGHT_CLASS_DEVICE doesn't guarantee that any of its
> dependencies are enabled, and these are complicated. Depending isn't ideal
> for configuration UI purposes, but is probably more appropriate here.
> 
> Signed-off-by: Matthew Garrett <matthew.garrett@nebula.com>
> ---
>  drivers/platform/x86/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 242c524..3338437 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -299,8 +299,8 @@ config IDEAPAD_LAPTOP
>  	depends on ACPI
>  	depends on RFKILL && INPUT
>  	depends on SERIO_I8042
> +	depends on BACKLIGHT_CLASS_DEVICE
>  	select INPUT_SPARSEKMAP
> -	select BACKLIGHT_CLASS_DEVICE
>  	help
>  	  This is a driver for Lenovo IdeaPad netbooks contains drivers for
>  	  rfkill switch, hotkey, fan control and backlight control.
> 

Acked-by: Ike Panhc <ike.pan@canonical.com>

It might be worthy to consider to apply the same modification for
ASUS_LAPTOP, SONY_LAPTOP, EEEPC_LAPTOP, ACPI_CMPC, SAMSUNG_Q10
and THINKPAD_ACPI to avoid the warning.