All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
To: Simon Horman <horms@verge.net.au>
Cc: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>,
	"kexec@lists.infradead.org" <kexec@lists.infradead.org>
Subject: kexec,x86: Use macro CRASH_MAX_MEMMAP_NR for clarification
Date: Tue, 26 Feb 2013 18:12:54 +0800	[thread overview]
Message-ID: <512C8AA6.2020503@cn.fujitsu.com> (raw)

For the allocation, using CRASH_MAX_MEMMAP_NR instead of KEXEC_MAX_SEGMENTS + 1 
seems more understandable.

Signed-off-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
---
 kexec/arch/i386/crashdump-x86.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kexec/arch/i386/crashdump-x86.c b/kexec/arch/i386/crashdump-x86.c
index 245402c..e4b8be3 100644
--- a/kexec/arch/i386/crashdump-x86.c
+++ b/kexec/arch/i386/crashdump-x86.c
@@ -975,7 +975,7 @@ int load_crashdump_segments(struct kexec_info *info, char* mod_cmdline,
                return -1; 
 
        /* Memory regions which panic kernel can safely use to boot into */
-       sz = (sizeof(struct memory_range) * (KEXEC_MAX_SEGMENTS + 1));
+       sz = (sizeof(struct memory_range) * CRASH_MAX_MEMMAP_NR);
        memmap_p = xmalloc(sz);
        memset(memmap_p, 0, sz);
        add_memmap(memmap_p, info->backup_src_start, info->backup_src_size);
-- 
1.7.1


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

             reply	other threads:[~2013-02-26 10:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-26 10:12 Zhang Yanfei [this message]
2013-03-05  1:43 ` kexec,x86: Use macro CRASH_MAX_MEMMAP_NR for clarification Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=512C8AA6.2020503@cn.fujitsu.com \
    --to=zhangyanfei@cn.fujitsu.com \
    --cc=d.hatayama@jp.fujitsu.com \
    --cc=horms@verge.net.au \
    --cc=kexec@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.