From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH] credit: track residual from divisions done during accounting Date: Tue, 26 Feb 2013 12:54:13 +0000 Message-ID: <512CB075.7050202@eu.citrix.com> References: <51222E8302000078000BF1F3@nat28.tlf.novell.com> <1361554003.16232.33.camel@Solace> <512B3CF702000078000C0AC6@nat28.tlf.novell.com> <512B4724.5000603@citrix.com> <512B594E02000078000C0BD1@nat28.tlf.novell.com> <512C9BD2.70903@eu.citrix.com> <512CAEA902000078000C10BF@nat28.tlf.novell.com> <20130226115229.GB93966@ocelot.phlegethon.org> <512CA3D3.3040002@citrix.com> <1361881287.7099.0.camel@hastur.hellion.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1361881287.7099.0.camel@hastur.hellion.org.uk> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Dario Faggioli , "Tim (Xen.org)" , David Vrabel , Jan Beulich , xen-devel List-Id: xen-devel@lists.xenproject.org On 02/26/2013 12:21 PM, Ian Campbell wrote: > On Tue, 2013-02-26 at 12:00 +0000, David Vrabel wrote: >> On 26/02/13 11:52, Tim Deegan wrote: >>> How about ASSERT(((typeof credits) val) == val) before the assignment? > > Why not just > ASSERT(credits == val); /* Ensure we haven't truncated val */ I prefer this one to having "typeof credits" in the ASSERT. The main thing is just to minimize the amount of effort a programmer has to expend trying to figure out what's going on, so he can spend it on something else. :-) -George