From: Laxman Dewangan <ldewangan@nvidia.com>
To: Ian Lartey <ian@slimlogic.co.uk>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
Graeme Gregory <gg@slimlogic.co.uk>
Subject: Re: [PATCH] mfd: palmas: is_palmas_charger needed by multiple drivers
Date: Tue, 26 Feb 2013 19:31:05 +0530 [thread overview]
Message-ID: <512CC021.4060201@nvidia.com> (raw)
In-Reply-To: <1361884572-27606-1-git-send-email-ian@slimlogic.co.uk>
On Tuesday 26 February 2013 06:46 PM, Ian Lartey wrote:
> is_palmas_charger checks for the presence of charging
> functionality in the device
>
> Signed-off-by: Graeme Gregory <gg@slimlogic.co.uk>
> Signed-off-by: Ian Lartey <ian@slimlogic.co.uk>
> ---
> include/linux/mfd/palmas.h | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/mfd/palmas.h b/include/linux/mfd/palmas.h
> index 3129f9a..98c0567 100644
> --- a/include/linux/mfd/palmas.h
> +++ b/include/linux/mfd/palmas.h
> @@ -26,6 +26,11 @@
> /* The ID_REVISION NUMBERS */
> #define PALMAS_CHIP_OLD_ID 0x0000
> #define PALMAS_CHIP_ID 0xC035
> +#define PALMAS_CHIP_CHARGER_ID 0xC036
> +
> +#define is_palmas(a) (((a) == PALMAS_CHIP_OLD_ID) || \
> + ((a) == PALMAS_CHIP_ID))
> +#define is_palmas_charger(a) ((a) == PALMAS_CHIP_CHARGER_ID)
>
TI says this as TPS80036 and original palma as TPS65913/TPS65914. Not
sure whether palma_charger is correct or not here.
But above change looks good.
Acked-by: Laxman Dewangan<ldewangan@nvidia.com>
next prev parent reply other threads:[~2013-02-26 14:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-26 13:16 [PATCH] mfd: palmas: is_palmas_charger needed by multiple drivers Ian Lartey
2013-02-26 14:01 ` Laxman Dewangan [this message]
2013-02-26 14:12 ` Graeme Gregory
-- strict thread matches above, loose matches on Subject: below --
2013-02-26 14:47 Ian Lartey
2013-03-04 10:44 ` Samuel Ortiz
2013-03-06 1:09 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512CC021.4060201@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=gg@slimlogic.co.uk \
--cc=grant.likely@secretlab.ca \
--cc=ian@slimlogic.co.uk \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.