From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabio Fantoni Subject: Re: [PATCH v2] tools: Improve make deb Date: Tue, 26 Feb 2013 15:16:44 +0100 Message-ID: <512CC3CC.2010505@heliman.it> References: <1361870886-3485-1-git-send-email-fantonifabio@tiscali.it> <1361884158.26546.291.camel@zakaz.uk.xensource.com> <1361884713.26546.296.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1361884713.26546.296.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: "fantonifabio@tiscali.it" , Ian Jackson , "xen-devel@lists.xensource.com" , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org Il 26/02/2013 14:18, Ian Campbell ha scritto: > On Tue, 2013-02-26 at 13:12 +0000, Stefano Stabellini wrote: >> On Tue, 26 Feb 2013, Ian Campbell wrote: >>> On Tue, 2013-02-26 at 12:58 +0000, Stefano Stabellini wrote: >>>>> +cat >deb/DEBIAN/postrm <>>>> +#!/bin/bash -e >>>>> +insserv -r xendomains && >>>>> +insserv -r xencommons >>> [...] >>>> All the changes look good to me >>> This one certainly isn't, calling insserv directly in a pre/post inst is >>> not the correct Debian interface to use. >>> >>> Better to call update-rc.d I think, or use dh_installinit (and grow a >>> build time dependency on debhelper). >> I am _very_ ignorant in deb packaging, but this wiki >> [...] >> maybe this is the recommended thing to do for sysadmins, not for >> packagers? > AIUI, yes. The document to refer to for anything to do with Debian > Packaging is the Debian Policy Manual: > http://www.debian.org/doc/debian-policy/ > > In this case: > http://www.debian.org/doc/debian-policy/ch-opersys.html#s9.3.3 > > Maintainers should use the abstraction layer provided by the > update-rc.d and invoke-rc.d programs to deal with initscripts in > their packages' scripts such as postinst, prerm and postrm. > > Directly managing the /etc/rc?.d links and directly invoking > the /etc/init.d/ initscripts should be done only by packages > providing the initscript subsystem (such as sysv-rc and > file-rc). > > Ian. > Sorry, Ian is right on this. I learned how to create deb packages according to the standards in the last months, I had better double check the patch. I'll redo init with update-rc.d in next patch version. The debian folder with compliance of deb policy 3.9.4 is probably loss of time that I can better use helping the official package. Are there other important things to do in "make deb"? Probably is sufficent, I used it for my testing system for one year for hundreds of fast test build without problem.