From: Alex Elder <elder@inktank.com>
To: akpm@linux-foundation.org, paul.clements@us.sios.com,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] nbd: fix sparse warning
Date: Tue, 26 Feb 2013 09:57:03 -0600 [thread overview]
Message-ID: <512CDB4F.9050902@inktank.com> (raw)
In-Reply-To: <512C335B.7010609@inktank.com>
I just fixed this in "drivers/block/rbd.c" and I noticed that
"drivers/block/nbd.c" has the same problem. Fix a warning
issued by sparse by adding some lockdep annotations
to indicate the queue lock gets dropped (because it's
held when do_nbd_request() is called) and re-acquired
within the function.
Signed-off-by: Alex Elder <elder@inktank.com>
---
drivers/block/nbd.c | 1 +
1 file changed, 1 insertion(+)
Index: b/drivers/block/nbd.c
===================================================================
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -551,6 +551,7 @@ static int nbd_thread(void *data)
*/
static void do_nbd_request(struct request_queue *q)
+ __releases(q->queue_lock) __acquires(q->queue_lock)
{
struct request *req;
parent reply other threads:[~2013-02-26 15:57 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <512C335B.7010609@inktank.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512CDB4F.9050902@inktank.com \
--to=elder@inktank.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.clements@us.sios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.