From: Darren Hart <dvhart@linux.intel.com>
To: Trevor Woerner <twoerner@gmail.com>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 5/7] mkdebugfs.sh: several fixes
Date: Tue, 26 Feb 2013 13:50:38 -0800 [thread overview]
Message-ID: <512D2E2E.20503@linux.intel.com> (raw)
In-Reply-To: <CAHUNapS=YynAbkmtj3NGha9vu2V_k1bDqW1gtPPe586N=shkUw@mail.gmail.com>
On 02/26/2013 09:43 AM, Trevor Woerner wrote:
> On Tue, Feb 26, 2013 at 4:24 AM, Robert Yang <liezhi.yang@windriver.com> wrote:
>> Fix mkdebugfs.sh:
>>
>> *)
>> echo "Unknown file $FILE" 1>&2
>> ;;
>> esac
>
> I know this doesn't come from your work, but since you're making
> changes, I think it would make for a better error message if the above
> said something along the lines of:
>
> echo "Unknown/unhandled file type '$(stat -c "%F" $FILE)' file:$FILE"
>
That's fine. Also, there is no need to send my script first and then
patch it. It was a 5 minute hack, so just modify and include as a single
patch.
--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel
next prev parent reply other threads:[~2013-02-26 22:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-26 9:24 [PATCH 0/7] Create ext* filesystems using debugfs Robert Yang
2013-02-26 9:24 ` [PATCH 1/7] e2fsprogs: upgrade to the git version (rename only) Robert Yang
2013-02-26 9:24 ` [PATCH 2/7] e2fsprogs: upgrade to the git version Robert Yang
2013-02-26 9:24 ` [PATCH 3/7] e2fsprogs: add the original mkdebugfs.sh Robert Yang
2013-02-26 9:24 ` [PATCH 4/7] mkdebugfs.sh: convert the tab to 4 spaces Robert Yang
2013-02-26 22:59 ` Darren Hart
2013-02-26 9:24 ` [PATCH 5/7] mkdebugfs.sh: several fixes Robert Yang
2013-02-26 17:43 ` Trevor Woerner
2013-02-26 21:50 ` Darren Hart [this message]
2013-02-26 9:24 ` [PATCH 6/7] e2fsprogs: ship mkfsdebug.sh Robert Yang
2013-02-26 21:49 ` Darren Hart
2013-02-26 9:24 ` [PATCH 7/7] image_types.bbclass: replace genext2fs with mkdebugfs.sh Robert Yang
2013-02-26 17:53 ` [PATCH 0/7] Create ext* filesystems using debugfs Trevor Woerner
2013-02-26 21:52 ` Darren Hart
2013-02-26 22:37 ` Trevor Woerner
2013-02-26 23:00 ` Darren Hart
2013-02-26 23:01 ` Trevor Woerner
2013-02-26 17:55 ` Saul Wold
2013-02-26 21:58 ` Darren Hart
2013-02-26 18:15 ` Phil Blundell
2013-02-26 22:03 ` Darren Hart
2013-02-27 2:25 ` Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512D2E2E.20503@linux.intel.com \
--to=dvhart@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=twoerner@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.