From: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org, Pete Eberlein <pete@sensoray.com>,
Hans Verkuil <hans.verkuil@cisco.com>
Subject: Re: [REVIEW PATCH 01/11] s2255: convert to the control framework.
Date: Tue, 26 Feb 2013 23:21:19 +0100 [thread overview]
Message-ID: <512D355F.2010309@gmail.com> (raw)
In-Reply-To: <f11ed501c392d8891c3eefeb4959a117e5ddf94e.1361900043.git.hans.verkuil@cisco.com>
Hi Hans,
On 02/26/2013 06:35 PM, Hans Verkuil wrote:
> diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h
> index dcd6374..f6ba2fc 100644
> --- a/include/uapi/linux/v4l2-controls.h
> +++ b/include/uapi/linux/v4l2-controls.h
> @@ -146,6 +146,10 @@ enum v4l2_colorfx {
> * of controls. We reserve 16 controls for this driver. */
> #define V4L2_CID_USER_MEYE_BASE (V4L2_CID_USER_BASE + 0x1000)
I couldn't find a patch adding this hunk in my e-mail archive so I'm
commenting here. Shouldn't V4L2_CID_USER_MEYE_BASE start at a higher value,
e.g. (V4L2_CID_USER_BASE + 0x1010) to account for drivers that already
use private controls ? There is couple of them with a few control IDs
starting at V4L2_CID_USER_BASE.
$ git grep V4L2_CID_USER_BASE
drivers/media/i2c/mt9p031.c:#define V4L2_CID_BLC_AUTO
(V4L2_CID_USER_BASE | 0x1002)
drivers/media/i2c/mt9p031.c:#define V4L2_CID_BLC_TARGET_LEVEL
(V4L2_CID_USER_BASE | 0x1003)
drivers/media/i2c/mt9p031.c:#define V4L2_CID_BLC_ANALOG_OFFSET
(V4L2_CID_USER_BASE | 0x1004)
drivers/media/i2c/mt9p031.c:#define V4L2_CID_BLC_DIGITAL_OFFSET
(V4L2_CID_USER_BASE | 0x1005)
drivers/media/i2c/mt9t001.c:#define V4L2_CID_TEST_PATTERN_COLOR
(V4L2_CID_USER_BASE | 0x1001)
drivers/media/i2c/mt9t001.c:#define V4L2_CID_BLACK_LEVEL_AUTO
(V4L2_CID_USER_BASE | 0x1002)
drivers/media/i2c/mt9t001.c:#define V4L2_CID_BLACK_LEVEL_OFFSET
(V4L2_CID_USER_BASE | 0x1003)
drivers/media/i2c/mt9t001.c:#define V4L2_CID_BLACK_LEVEL_CALIBRATE
(V4L2_CID_USER_BASE | 0x1004)
drivers/media/i2c/mt9v032.c:#define V4L2_CID_TEST_PATTERN_COLOR
(V4L2_CID_USER_BASE | 0x1001)
drivers/media/platform/mem2mem_testdev.c:#define
V4L2_CID_TRANS_TIME_MSEC (V4L2_CID_USER_BASE + 0x1000)
drivers/media/platform/mem2mem_testdev.c:#define V4L2_CID_TRANS_NUM_BUFS
(V4L2_CID_USER_BASE + 0x1001)
drivers/media/platform/vivi.c:#define VIVI_CID_CUSTOM_BASE
(V4L2_CID_USER_BASE | 0xf000)
drivers/media/usb/cpia2/cpia2_v4l.c:#define CPIA2_CID_USB_ALT
(V4L2_CID_USER_BASE | 0xf000)
drivers/media/usb/pwc/pwc-v4l.c:#define PWC_CID_CUSTOM(ctrl)
((V4L2_CID_USER_BASE | 0xf000) + custom_ ## ctrl)
drivers/staging/media/davinci_vpfe/davinci_vpfe_user.h:#define
VPFE_ISIF_CID_CRGAIN (V4L2_CID_USER_BASE | 0xa001)
drivers/staging/media/davinci_vpfe/davinci_vpfe_user.h:#define
VPFE_ISIF_CID_CGRGAIN (V4L2_CID_USER_BASE | 0xa002)
drivers/staging/media/davinci_vpfe/davinci_vpfe_user.h:#define
VPFE_ISIF_CID_CGBGAIN (V4L2_CID_USER_BASE | 0xa003)
drivers/staging/media/davinci_vpfe/davinci_vpfe_user.h:#define
VPFE_ISIF_CID_CBGAIN (V4L2_CID_USER_BASE | 0xa004)
drivers/staging/media/davinci_vpfe/davinci_vpfe_user.h:#define
VPFE_ISIF_CID_GAIN_OFFSET (V4L2_CID_USER_BASE | 0xa005)
drivers/staging/media/davinci_vpfe/davinci_vpfe_user.h:#define
VPFE_CID_DPCM_PREDICTOR (V4L2_CID_USER_BASE | 0xa006)
include/uapi/linux/v4l2-controls.h:#define V4L2_CID_USER_BASE
V4L2_CID_BASE
include/uapi/linux/v4l2-controls.h:#define V4L2_CID_USER_MEYE_BASE
(V4L2_CID_USER_BASE + 0x1000)
And also
$ git grep V4L2_CTRL_CLASS_CAMERA
drivers/media/i2c/mt9t001.c:#define V4L2_CID_GAIN_RED
(V4L2_CTRL_CLASS_CAMERA | 0x1001)
drivers/media/i2c/mt9t001.c:#define V4L2_CID_GAIN_GREEN_RED
(V4L2_CTRL_CLASS_CAMERA | 0x1002)
drivers/media/i2c/mt9t001.c:#define V4L2_CID_GAIN_GREEN_BLUE
(V4L2_CTRL_CLASS_CAMERA | 0x1003)
drivers/media/i2c/mt9t001.c:#define V4L2_CID_GAIN_BLUE
(V4L2_CTRL_CLASS_CAMERA | 0x1004)
drivers/media/i2c/s5k6aa.c:#define V4L2_CID_RED_GAIN
(V4L2_CTRL_CLASS_CAMERA | 0x1001)
drivers/media/i2c/s5k6aa.c:#define V4L2_CID_GREEN_GAIN
(V4L2_CTRL_CLASS_CAMERA | 0x1002)
drivers/media/i2c/s5k6aa.c:#define V4L2_CID_BLUE_GAIN
(V4L2_CTRL_CLASS_CAMERA | 0x1003)
> +/* The base for the s2255 driver controls.
> + * We reserve 8 controls for this driver. */
> +#define V4L2_CID_USER_S2255_BASE (V4L2_CID_USER_BASE + 0x1010)
> +
--
Regards,
Sylwester
next prev parent reply other threads:[~2013-02-26 22:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-26 17:35 s2255: v4l2 compliance fixes Hans Verkuil
2013-02-26 17:35 ` [REVIEW PATCH 01/11] s2255: convert to the control framework Hans Verkuil
2013-02-26 17:35 ` [REVIEW PATCH 02/11] s2255: add V4L2_CID_JPEG_COMPRESSION_QUALITY Hans Verkuil
2013-02-26 17:35 ` [REVIEW PATCH 03/11] s2255: add support for control events and prio handling Hans Verkuil
2013-02-26 17:35 ` [REVIEW PATCH 04/11] s2255: add device_caps support to querycap Hans Verkuil
2013-02-26 17:35 ` [REVIEW PATCH 05/11] s2255: fixes in the way standards are handled Hans Verkuil
2013-02-26 17:35 ` [REVIEW PATCH 06/11] s2255: zero priv and set colorspace Hans Verkuil
2013-02-26 17:35 ` [REVIEW PATCH 07/11] s2255: fix field handling Hans Verkuil
2013-02-26 17:35 ` [REVIEW PATCH 08/11] s2255: don't zero struct v4l2_streamparm Hans Verkuil
2013-02-26 17:35 ` [REVIEW PATCH 09/11] s2255: Add ENUM_FRAMESIZES support Hans Verkuil
2013-02-26 17:35 ` [REVIEW PATCH 10/11] s2255: choose YUYV as the default format, not YUV422P Hans Verkuil
2013-02-26 17:35 ` [REVIEW PATCH 11/11] s2255: fix big-endian support Hans Verkuil
2013-02-26 22:21 ` Sylwester Nawrocki [this message]
2013-02-27 9:05 ` [REVIEW PATCH 01/11] s2255: convert to the control framework Hans Verkuil
2013-02-27 22:10 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512D355F.2010309@gmail.com \
--to=sylvester.nawrocki@gmail.com \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=pete@sensoray.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.