From: Gao feng <gaofeng@cn.fujitsu.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH] net: dev: deinit list in unregister_netdevice_many
Date: Wed, 27 Feb 2013 15:31:26 +0800 [thread overview]
Message-ID: <512DB64E.6010103@cn.fujitsu.com> (raw)
In-Reply-To: <20130227.022125.374228548587492555.davem@davemloft.net>
On 2013/02/27 15:21, David Miller wrote:
>
> mroute_clean_tables() uses the list after unregister_netdevice_many().
>
You mean list_for_each_entry_safe(c, next, &mrt->mfc_cache_array[i], list)
in mroute_clean_tables()?
Isn't this list just a member of struct mfc_cache?
I can't find the other codes in mroute_clean_tables uses this list
after unregister_netdevice_many.
> Can you please just stop tinkering in this area? You are making many
> careless errors.
>
Ok,I am fine if you drop this patch,just as commit ceaaec98ad99859ac90ac6863ad0a6cd075d8e0e
said "device is freed without touching its unreg_list". there will be no serious problems
if we don't have this patch.
prev parent reply other threads:[~2013-02-27 7:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 6:59 [PATCH] net: dev: deinit list in unregister_netdevice_many Gao feng
2013-02-27 7:12 ` Eric Dumazet
2013-02-27 7:25 ` Eric Dumazet
2013-02-27 7:21 ` David Miller
2013-02-27 7:31 ` Gao feng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512DB64E.6010103@cn.fujitsu.com \
--to=gaofeng@cn.fujitsu.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.