From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Chen Gang <gang.chen@asianux.com>
Cc: "konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
"jbeulich@suse.com" <jbeulich@suse.com>,
Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
"dgdegra@tycho.nsa.gov" <dgdegra@tycho.nsa.gov>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers/block/xen-blkback: preq.dev is used without initialized
Date: Wed, 27 Feb 2013 10:50:18 +0100 [thread overview]
Message-ID: <512DD6DA.5010706@citrix.com> (raw)
In-Reply-To: <512D90F2.9070200@asianux.com>
On 27/02/13 05:52, Chen Gang wrote:
>
> if call xen_vbd_translate failed, the preq.dev will be not initialized.
> so use blkif->vbd.pdevice instead (still better to print relative info).
preq.dev is initialized a a couple of lines prior to calling
xen_vbd_translate:
preq.dev = req->u.rw.handle;
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> drivers/block/xen-blkback/blkback.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c
> index de1f319..6d1cc3d 100644
> --- a/drivers/block/xen-blkback/blkback.c
> +++ b/drivers/block/xen-blkback/blkback.c
> @@ -904,7 +904,8 @@ static int dispatch_rw_block_io(struct xen_blkif *blkif,
> pr_debug(DRV_PFX "access denied: %s of [%llu,%llu] on dev=%04x\n",
> operation == READ ? "read" : "write",
> preq.sector_number,
> - preq.sector_number + preq.nr_sects, preq.dev);
> + preq.sector_number + preq.nr_sects,
> + blkif->vbd.pdevice);
> goto fail_response;
> }
>
>
next prev parent reply other threads:[~2013-02-27 9:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 4:52 [PATCH] drivers/block/xen-blkback: preq.dev is used without initialized Chen Gang
2013-02-27 9:49 ` Jan Beulich
2013-02-27 9:49 ` Jan Beulich
2013-02-27 9:50 ` Roger Pau Monné [this message]
2013-02-27 10:03 ` Jan Beulich
2013-02-27 9:57 ` Jan Beulich
2013-02-27 10:38 ` Chen Gang
2013-02-27 10:45 ` Jan Beulich
2013-02-27 10:45 ` Jan Beulich
2013-02-27 15:40 ` Konrad Rzeszutek Wilk
2013-02-27 15:40 ` Konrad Rzeszutek Wilk
2013-02-28 1:20 ` Chen Gang
2013-02-28 1:20 ` Chen Gang
2013-02-27 10:38 ` Chen Gang
2013-02-27 9:57 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512DD6DA.5010706@citrix.com \
--to=roger.pau@citrix.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=gang.chen@asianux.com \
--cc=jbeulich@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.