Re: [PATCH] serial: ifx6x60: add missing variable initialization

[Jiri Slaby <jslaby@suse.cz>]

On 02/27/2013 06:03 AM, Jingoo Han wrote:
> Fixed build warning as below:
> 
> drivers/tty/serial/ifx6x60.c:753:8: warning: 'more' may be used uninitialized in this function [-Wuninitialized]

This needs some more investigation and explanation than that. Are you
fixing a real compiler warning or hiding a bug here?

> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
>  drivers/tty/serial/ifx6x60.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/tty/serial/ifx6x60.c b/drivers/tty/serial/ifx6x60.c
> index 68d7ce9..3d78baf 100644
> --- a/drivers/tty/serial/ifx6x60.c
> +++ b/drivers/tty/serial/ifx6x60.c
> @@ -687,7 +687,7 @@ static void ifx_spi_complete(void *ctx)
>  	struct tty_ldisc *ldisc = NULL;
>  	int length;
>  	int actual_length;
> -	unsigned char more;
> +	unsigned char more = 0;
>  	unsigned char cts;
>  	int local_write_pending = 0;
>  	int queue_length;
> 


-- 
js
suse labs