All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Horia Geantă" <horia.geanta@freescale.com>
To: Vakul Garg <vakul@freescale.com>
Cc: <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH] crypto: caam - fix job ring cleanup code
Date: Wed, 27 Feb 2013 18:07:47 +0200	[thread overview]
Message-ID: <512E2F53.7030305@freescale.com> (raw)
In-Reply-To: <1357815971-31462-1-git-send-email-vakul@freescale.com>

On 1/10/2013 1:06 PM, Vakul Garg wrote:
> The job ring init function creates a platform device for each job ring.
> While the job ring is shutdown, e.g. while module removal, its platform
> device was not being removed. This lead to failure while reinserting
> caam module again. Same problem appears while platform device for caam
> is bound, unbound and then bound again to caam platform driver.
>
> Signed-off-by: Vakul Garg <vakul@freescale.com>
> Signed-off-by: Bharat Bhushan <bharat.bhushan@freescale.com>

Not sure I understand the commit message. You seem to explain there are 
two problems, but I see only one: caam module being reinserted.

I guess a stack traceback in the commit message wouldn't hurt.

Regards,
Horia

      reply	other threads:[~2013-02-27 16:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-10 11:06 [PATCH] crypto: caam - fix job ring cleanup code Vakul Garg
2013-02-27 16:07 ` Horia Geantă [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=512E2F53.7030305@freescale.com \
    --to=horia.geanta@freescale.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=vakul@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.