Re: [PATCH] crypto: testmgr - add aead cbc des, des3_ede tests.

["Horia Geantă" <horia.geanta@freescale.com>]

On 1/9/2013 9:17 AM, Vakul Garg wrote:
> Test vectors were taken from existing test for CBC(DES3_EDE).
> Associated data has been added to test vectors.
> HMAC computed with Crypto++ has been used.
> Following algos have been covered.
>
> 	(a) "authenc(hmac(sha1),cbc(des))"
> 	(b) "authenc(hmac(sha1),cbc(des3_ede))"
> 	(c) "authenc(hmac(sha224),cbc(des))"
> 	(d) "authenc(hmac(sha224),cbc(des3_ede))"
> 	(e) "authenc(hmac(sha256),cbc(des))"
> 	(f) "authenc(hmac(sha256),cbc(des3_ede))"
> 	(g) "authenc(hmac(sha384),cbc(des))"
> 	(h) "authenc(hmac(sha384),cbc(des3_ede))"
> 	(i) "authenc(hmac(sha512),cbc(des))"
> 	(j) "authenc(hmac(sha512),cbc(des3_ede))"
>
> Signed-off-by: Vakul Garg <vakul@freescale.com>
> ---
>   crypto/testmgr.c |  120 ++++++++++
>   crypto/testmgr.h |  647 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>   2 files changed, 767 insertions(+), 0 deletions(-)

A good idea would be to cross-check by verifying that both caam and 
talitos pass these builtin tests, if you haven't done so already.
If you have other platforms at hand, the more the better.

Some time ago I wanted to add support for cbc(des), but Kim argued it 
ain't worth the effort due to low interest in des algo. But since you 
already did the work and submitted the patch, I guess it's fine.

Regards,
Horia