From: Chen Gang <gang.chen@asianux.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Jan Beulich <JBeulich@suse.com>,
roger.pau@citrix.com, stefano.stabellini@eu.citrix.com,
dgdegra@tycho.nsa.gov
Cc: xen-devel <xen-devel@lists.xen.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH v2] drivers/block/xen-blkback: preq.dev is used without initialized
Date: Thu, 28 Feb 2013 10:34:23 +0800 [thread overview]
Message-ID: <512EC22F.5020404@asianux.com> (raw)
if call xen_vbd_translate failed, the preq.dev will be not initialized.
so use blkif->vbd.pdevice instead (still better to print relative info).
additional information:
before commit 01c681d4c70d64cb72142a2823f27c4146a02e63, the value printed
here was bogus, as it was the guest provided value from req->u.rw.handle
rather than the actual device.
Signed-off-by: Chen Gang <gang.chen@asianux.com>
Acked-by: Jan Beulich <JBeulich@suse.com>
---
drivers/block/xen-blkback/blkback.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c
index de1f319..6d1cc3d 100644
--- a/drivers/block/xen-blkback/blkback.c
+++ b/drivers/block/xen-blkback/blkback.c
@@ -904,7 +904,8 @@ static int dispatch_rw_block_io(struct xen_blkif *blkif,
pr_debug(DRV_PFX "access denied: %s of [%llu,%llu] on dev=%04x\n",
operation == READ ? "read" : "write",
preq.sector_number,
- preq.sector_number + preq.nr_sects, preq.dev);
+ preq.sector_number + preq.nr_sects,
+ blkif->vbd.pdevice);
goto fail_response;
}
--
1.7.7.6
next reply other threads:[~2013-02-28 2:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-28 2:34 Chen Gang [this message]
2013-03-01 13:43 ` [PATCH v2] drivers/block/xen-blkback: preq.dev is used without initialized Konrad Rzeszutek Wilk
2013-03-01 13:43 ` Konrad Rzeszutek Wilk
2013-03-05 0:54 ` Chen Gang
2013-03-05 0:54 ` Chen Gang
2013-04-03 12:56 ` William Dauchy
2013-04-03 12:56 ` William Dauchy
2013-04-03 13:01 ` Jan Beulich
2013-04-03 13:01 ` Jan Beulich
2013-04-03 13:25 ` William Dauchy
2013-04-03 13:42 ` Jan Beulich
2013-04-03 13:56 ` William Dauchy
2013-04-03 14:34 ` Jan Beulich
2013-04-03 16:37 ` Konrad Rzeszutek Wilk
2013-04-03 16:37 ` Konrad Rzeszutek Wilk
2013-04-03 14:34 ` Jan Beulich
2013-04-03 13:56 ` William Dauchy
2013-04-03 13:42 ` Jan Beulich
2013-04-03 13:25 ` William Dauchy
-- strict thread matches above, loose matches on Subject: below --
2013-02-28 2:34 Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512EC22F.5020404@asianux.com \
--to=gang.chen@asianux.com \
--cc=JBeulich@suse.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roger.pau@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.