From: Laxman Dewangan <ldewangan@nvidia.com>
To: Ian Lartey <ian@slimlogic.co.uk>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"j-keerthy@ti.com" <j-keerthy@ti.com>,
"gg@slimlogic.co.uk" <gg@slimlogic.co.uk>,
"wim@iguana.be" <wim@iguana.be>,
"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>
Subject: Re: [PATCH 1/2] watchdog: add Palmas Watchdog support
Date: Thu, 28 Feb 2013 11:20:10 +0530 [thread overview]
Message-ID: <512EF012.7080006@nvidia.com> (raw)
In-Reply-To: <1361990168-882-1-git-send-email-ian@slimlogic.co.uk>
On Thursday 28 February 2013 12:06 AM, Ian Lartey wrote:
> From: Graeme Gregory <gg@slimlogic.co.uk>
>
> Add support for the Palmas watchdog timer which has a timeout configurable
> from 1s to 128s.
>
> Signed-off-by: Graeme Gregory <gg@slimlogic.co.uk>
> Signed-off-by: Ian Lartey <ian@slimlogic.co.uk>
> ---
> drivers/watchdog/palmas_wdt.c | 291 +++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 291 insertions(+), 0 deletions(-)
> create mode 100644 drivers/watchdog/palmas_wdt.c
patch 1 and 2 can be merge as single patch.
generic comment, we have proper watchdog framework where we can have
some api for watchdog_ops and register as watchdog_register_device().
Then core parts take care of the all fileops/sysfs interface.
This need not to be develop locally.
You can refer wm831x_wdt.c, wm8350_wdt.c driver for more reference where
it is really used watchdog framework.
I think you can use the watchdog framework for this.
prev parent reply other threads:[~2013-02-28 5:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 18:36 [PATCH 1/2] watchdog: add Palmas Watchdog support Ian Lartey
2013-02-27 18:36 ` [PATCH 2/2] watchdog: Kconfig for Palmas watchdog driver Ian Lartey
2013-02-27 18:38 ` [PATCH 1/2] watchdog: add Palmas Watchdog support Stephen Warren
2013-02-27 20:17 ` Ian Lartey
2013-02-27 20:36 ` Stephen Warren
2013-02-27 22:29 ` Ian Lartey
2013-02-28 5:50 ` Laxman Dewangan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512EF012.7080006@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=gg@slimlogic.co.uk \
--cc=grant.likely@secretlab.ca \
--cc=ian@slimlogic.co.uk \
--cc=j-keerthy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.